Conversation
…selection functionality
Contributor
|
Hello! Some merge conflicts in this PR - can you please update 🙏 Thanks! |
Contributor
Author
|
@ofahimIQSS, I solved merge conflicts locally but I can still see them here, weird. I will wait, maybe is a github sincronization thing. |
Contributor
Author
|
@ofahimIQSS merge conflicts solved and all tests are passing 👍🏼 |
Contributor
|
Thanks ,Just need a review now 😃 |
Contributor
Author
|
@ekraffmiller could you please review again? I just solved some merge conflicts |
Contributor
Author
|
@ofahimIQSS ready again 👍🏼 |
Contributor
Author
|
Merge conflicts solved again, @ChengShi-1 could you reapprove? thanks and sorry 🙏🏼 |
Contributor
|
Functionality looks great. Thank you for the PR. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Replicate the replace file feature from JSF, both from the Edit File options in File Page and Dataset Page file item in files list.
The Replace File button was added only on the File Page, I will add it in the Dataset Files table in another iteration to avoid too many merge conflicts right now.
Which issue(s) this PR closes:
Special notes for your reviewer:
This is inspired in the existing File Uploader. It was refactored to work for both adding files to a dataset and replacing a file.
We have removed the restrict and tags functionalities, we will do that in a future iteration and discuss about different approaches before.
Some TODO's are analyse duplicate file contents and remove files from the S3 by their storage id(API endpoint required)
New features:
Suggestions on how to test this:
Suggestions on how to test this:
Step 1: Run the Development Environment
npm i.cd packages/design-system && npm i && npm run build.cd ../../..envfile similar to.env.example, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000.cd dev-env../run-env.sh unstable.Step 2: Test the feature
Upload files to a dataset:
*should work same way as in SPA beta environment, but we removed restrict and tags functionality for now as mentioned above.
Replace File functionality:
Leave page confirmation modal:
This works for both modes (add files to dataset and replace file), when you have uploaded some files already or you are uploading them, if you try to leave the page without saving changes a leave page confirmation modal will appear.
You can leave the page by clicking on a in app link or by just clicking the browser back button.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes.
Replace File mode.

Add Files to dataset mode.

Field validations



Different File Type modal, on replace file mode.

Leave page confirmation modal, when you try to leave the page but you already uploaded some files.
