Merged
Conversation
Contributor
Author
|
@ChengShi-1 , this one also ready for review. |
ChengShi-1
previously approved these changes
Apr 1, 2025
Contributor
There was a problem hiding this comment.
Good. I don't see any problem after inspecting code and playing the page around.
@g-saracca There is one merge conflict, could you resolve it? Thanks!
Contributor
Author
|
Thanks @ChengShi-1 , conflicts solved |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What this PR does / why we need it:
Enhance the not found page.
It adds a page for when the route is not found by the router and another one for when a file, dataset or collection is not found.
It replace the existing Not Found Page alert.
Which issue(s) this PR closes:
Suggestions on how to test this:
Step 1: Run the Development Environment
npm i.cd packages/design-system && npm i && npm run build.cd ../../..envfile similar to.env.example, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000.cd dev-env../run-env.sh unstable.Step 2: Test the feature
persistentIdquery param to one that does not exist, reload page, you should see now the Not Found Page with the 'Dataset' word in bold.idquery param to one that does not exist, reload page, you should see now the Not Found Page with the 'File' word in bold.Does this PR introduce a user interface change? If mockups are available, please link/include them here: