Skip to content

Comments

Enhanced Not Found Page#633

Merged
ofahimIQSS merged 14 commits intodevelopfrom
feat/621-enhance-not-found-page
Apr 3, 2025
Merged

Enhanced Not Found Page#633
ofahimIQSS merged 14 commits intodevelopfrom
feat/621-enhance-not-found-page

Conversation

@g-saracca
Copy link
Contributor

What this PR does / why we need it:

Enhance the not found page.
It adds a page for when the route is not found by the router and another one for when a file, dataset or collection is not found.
It replace the existing Not Found Page alert.

Which issue(s) this PR closes:

Suggestions on how to test this:

Step 1: Run the Development Environment

  1. Execute npm i.
  2. Navigate with cd packages/design-system && npm i && npm run build.
  3. Return with cd ../../.
  4. Ensure you have a .env file similar to .env.example, with the variable VITE_DATAVERSE_BACKEND_URL=http://localhost:8000.
  5. Navigate with cd dev-env.
  6. Start the environment using ./run-env.sh unstable.
  7. To verify the environment, visit http://localhost:8000 and check your local Dataverse installation.

Step 2: Test the feature

  1. Create a collection, a dataset and a file.
  2. Navigate to that collection and change the collection alias in the url to one that does not exist, reload page, you should see now the Not Found Page with the 'Collection' word in bold.
  3. Navigate to the dataset page and modify the persistentId query param to one that does not exist, reload page, you should see now the Not Found Page with the 'Dataset' word in bold.
  4. Navigate to the file page and modify the id query param to one that does not exist, reload page, you should see now the Not Found Page with the 'File' word in bold.
  5. Finally type a not existing url within the spa app, like 'localhost:8000/spa/foo', you should see now the default Not Found Page with the 'Page' word in bold.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Screen Shot 2025-03-26 at 16 11 28 Screen Shot 2025-03-26 at 16 11 54 Screen Shot 2025-03-26 at 16 12 08 Screen Shot 2025-03-26 at 16 12 16

@g-saracca g-saracca added Size: 3 A percentage of a sprint. 2.1 hours. GREI Re-arch GREI re-architecture-related Original size: 3 FY25 Sprint 19 FY25 Sprint 19 (2025-03-12 - 2025-03-26) SPA.Q1.11 Enhanced Not Found Page labels Mar 26, 2025
@g-saracca g-saracca moved this to Ready for Review ⏩ in IQSS Dataverse Project Mar 26, 2025
@coveralls
Copy link

coveralls commented Mar 26, 2025

Coverage Status

coverage: 97.713% (-0.4%) from 98.075%
when pulling a468501 on feat/621-enhance-not-found-page
into b9f3906 on develop.

@cmbz cmbz added the FY25 Sprint 20 FY25 Sprint 20 (2025-03-26 - 2025-04-09) label Mar 30, 2025
@g-saracca
Copy link
Contributor Author

@ChengShi-1 , this one also ready for review.

@ChengShi-1 ChengShi-1 self-requested a review March 31, 2025 22:53
@ChengShi-1 ChengShi-1 self-assigned this Mar 31, 2025
@ChengShi-1 ChengShi-1 moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Mar 31, 2025
ChengShi-1
ChengShi-1 previously approved these changes Apr 1, 2025
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. I don't see any problem after inspecting code and playing the page around.

@g-saracca There is one merge conflict, could you resolve it? Thanks!

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Apr 1, 2025
@g-saracca
Copy link
Contributor Author

Thanks @ChengShi-1 , conflicts solved

@g-saracca g-saracca assigned ChengShi-1 and unassigned ChengShi-1 Apr 1, 2025
@ChengShi-1 ChengShi-1 self-requested a review April 1, 2025 18:10
@ChengShi-1 ChengShi-1 removed their assignment Apr 1, 2025
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@ofahimIQSS ofahimIQSS self-assigned this Apr 3, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Apr 3, 2025
@ofahimIQSS
Copy link
Contributor

Looks good from my end:

image
image
image
image

@ofahimIQSS ofahimIQSS merged commit 51f1d84 into develop Apr 3, 2025
14 checks passed
@ofahimIQSS ofahimIQSS deleted the feat/621-enhance-not-found-page branch April 3, 2025 16:16
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Apr 3, 2025
@ofahimIQSS ofahimIQSS removed their assignment Apr 3, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 19 FY25 Sprint 19 (2025-03-12 - 2025-03-26) FY25 Sprint 20 FY25 Sprint 20 (2025-03-26 - 2025-04-09) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q1.11 Enhanced Not Found Page

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Enhanced Not Found Page

5 participants