Dataset download count metrics integration#638
Merged
ofahimIQSS merged 6 commits intodevelopfrom Apr 7, 2025
Merged
Conversation
github-actions
bot
added
FY25 Sprint 20
g-saracca
changed the title
ChengShi-1
previously approved these changes
Apr 4, 2025
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
Author
|
thanks @ChengShi-1, merge conflicts solved 👍🏼 , you will need to review again after tests pass |
Contributor
|
I see one pending check: UI Review: dataverse-frontend |
Contributor
|
@ofahimIQSS Thanks Omer, it is approved |
Contributor
|
Looks good from my side - merging
|
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Replicates the JSF Classic Download Metrics count in the Dataset Page.
I just change a little bit how it looks in the JSF UI.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Create a dataset, upload a file and publish the dataset.
Download a file, refresh the dataset page and you should see the correct download count. 👇
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes.
When MDC is not enabled.
When MDC is enabled, this is a screenshot from a storybook story.
