File Page: Restrict Modal update restrict access and terms#641
Merged
ofahimIQSS merged 13 commits intodevelopfrom Apr 8, 2025
Merged
Conversation
github-actions
bot
added
FY25 Sprint 20
ChengShi-1
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
ChengShi-1
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
…t-terms-of-access
g-saracca
requested changes
Apr 4, 2025
Contributor
g-saracca
left a comment
g-saracca
left a comment
There was a problem hiding this comment.
Some requested changes.
Also some UI points:
- The link to the guides should use latest instead of fixed version:
"https://guides.dataverse.org/en/6.5/user/..." to "https://guides.dataverse.org/en/latest/user/..."
Also you should use a normal<a/>tag with a target _blank so it opens the link in a new tab and include the link text in the translations with <Trans component. See this example. - Add
<QuestionMarkTooltip />to "Request Access" and "Terms of Access for Restricted Files" labels, see JSF version of the modal. There are lot of examples of how to use it within the SPA code. - Reset form fields values when closing the modal.
src/dataset/infrastructure/repositories/DatasetJSDataverseRepository.ts
Outdated
Show resolved
Hide resolved
src/sections/file/file-action-buttons/edit-file-menu/restrict-file-button/useRestrictFile.tsx
Outdated
Show resolved
Hide resolved
…ess' of https://github.com/IQSS/dataverse-frontend into 639-file-page-file-restrict-access-request-terms-of-access
g-saracca
approved these changes
Apr 7, 2025
Contributor
g-saracca
left a comment
g-saracca
left a comment
There was a problem hiding this comment.
Looks good now, thanks!
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
Looks good, merging:
|
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
ofahimIQSS
deleted the
639-file-page-file-restrict-access-request-terms-of-access
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In edit file restriction feature, we're missing File Restriction Access Request & Terms of Access
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
npm i
Please test it on both file page and dataset page > File tab for every single file.
Also, check some rules below:
If restrict is true and enableAccessRequest is false then termsOfAccess is required.
The enableAccessRequest and termsOfAccess are applied to the Draft version of the Dataset and affect all of the restricted files in said Draft version.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: