Skip to content

Conversation

@ChengShi-1
Copy link
Contributor

What this PR does / why we need it:

add a word-break of long text to the collection&dataset&file card and breadcrumb, to prevent a UI break.

The card extends too long if we have a long text without space
image

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

entering a long title/description to collection, dataset and file
image

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes or changelog update needed for this change?:

Additional documentation:

@github-actions github-actions bot added bug Something isn't working FY26 Sprint 7 FY26 Sprint 7 (2025-09-24 - 2025-10-08) GREI Re-arch GREI re-architecture-related labels Oct 6, 2025
@ChengShi-1 ChengShi-1 changed the title feat: add wordbreak to all cards Fix: add line break to all items' title and description for long text w/o spacing Oct 6, 2025
@ChengShi-1 ChengShi-1 added the Size: 0.5 A percentage of a sprint. 0.35 hours label Oct 6, 2025
@coveralls
Copy link

coveralls commented Oct 6, 2025

Coverage Status

coverage: 97.699% (+0.5%) from 97.227%
when pulling d681473 on 839-wrappers-break-when-entering-long-descriptions-without-spacing-on-datasets
into a3f4b8b on develop.

@ChengShi-1 ChengShi-1 requested a review from Copilot October 6, 2025 20:07
@ChengShi-1 ChengShi-1 marked this pull request as ready for review October 6, 2025 20:07
@ChengShi-1 ChengShi-1 moved this to Ready for Review ⏩ in IQSS Dataverse Project Oct 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes UI layout issues caused by long text without spaces in collection, dataset, and file cards by adding word-break CSS properties to prevent horizontal overflow.

  • Adds word-break: break-word CSS property to card components and breadcrumbs
  • Includes test coverage for long unspaced titles to prevent regression
  • Updates changelog to document the fix

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
CollectionCard.spec.tsx Adds test to verify long unspaced titles don't cause horizontal overflow
BreadcrumbsGenerator.module.scss Adds word-break property to breadcrumb component
Citation.module.scss Adds word-break property to citation description
FileCard.module.scss Adds word-break property to file card component
DatasetCard.module.scss Adds word-break property to dataset card component
CollectionCard.module.scss Adds word-break property to collection card component
CHANGELOG.md Documents the UI fix in changelog

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <[email protected]>
@g-saracca g-saracca self-assigned this Oct 8, 2025
@g-saracca g-saracca moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Oct 8, 2025
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion to the CHANGELOG but approving already 👍🏼 Nice fix!
And there are some merge conflicts in CHANGELOG file

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Oct 8, 2025
@g-saracca g-saracca assigned ChengShi-1 and unassigned g-saracca Oct 8, 2025
@g-saracca g-saracca moved this from Ready for QA ⏩ to In Review 🔎 in IQSS Dataverse Project Oct 8, 2025
@g-saracca g-saracca moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Oct 8, 2025
@ofahimIQSS ofahimIQSS self-assigned this Oct 8, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Oct 8, 2025
@ChengShi-1
Copy link
Contributor Author

image Add a line to fix the long keyword terms

@cmbz cmbz added the FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) label Oct 8, 2025
@ofahimIQSS
Copy link
Contributor

@ChengShi-1 theres a merge conflict - could you please update - thanks!

@ofahimIQSS
Copy link
Contributor

very nice - merging

Uploading Screen Recording 2025-10-09 at 2.41.23 PM.mov…

@ofahimIQSS ofahimIQSS merged commit 322f73f into develop Oct 9, 2025
12 of 14 checks passed
@ofahimIQSS ofahimIQSS deleted the 839-wrappers-break-when-entering-long-descriptions-without-spacing-on-datasets branch October 9, 2025 18:43
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Oct 9, 2025
@ofahimIQSS ofahimIQSS removed their assignment Oct 9, 2025
@pdurbin pdurbin moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working FY26 Sprint 7 FY26 Sprint 7 (2025-09-24 - 2025-10-08) FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) GREI Re-arch GREI re-architecture-related Size: 0.5 A percentage of a sprint. 0.35 hours

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Wrappers break when entering long descriptions without spacing on datasets

6 participants