Skip to content

Conversation

@ekraffmiller
Copy link
Contributor

What this PR does / why we need it:

Fixes the style for Custom Featured Items, so they display corrrectly in Safari

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

To test, create a custom featured Item that contains a header image, some text and bullet points, so that the content has to be trimmed in the Featured Item card. View the Card in Safari and Chrome. It should crop the content correctly, in both browsers. See the issue for screenshot example of the problem.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

@github-actions github-actions bot added bug Something isn't working FY26 Sprint 10 FY26 Sprint 10 (2025-11-05 - 2025-11-19) FY26 Sprint 11 FY26 Sprint 11 (2025-11-20 - 2025-12-03) FY26 Sprint 12 FY26 Sprint 12 (2025-12-03 - 2025-12-17) FY26 Sprint 13 FY26 Sprint 13 (2025-12-17 - 2025-12-31) FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) GREI Re-arch GREI re-architecture-related labels Jan 5, 2026
@ekraffmiller ekraffmiller moved this to Ready for Review ⏩ in IQSS Dataverse Project Jan 5, 2026
@coveralls
Copy link

coveralls commented Jan 5, 2026

Coverage Status

coverage: 97.795% (+0.008%) from 97.787%
when pulling 0c26684 on 890-fix-featured-item-styling
into 012e15c on develop.

@ChengShi-1 ChengShi-1 self-assigned this Jan 6, 2026
@ChengShi-1 ChengShi-1 moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Jan 6, 2026
@ChengShi-1 ChengShi-1 self-requested a review January 7, 2026 16:04
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ellen, thanks for the fix.
There is a small behavior change. When the text is too long to display, the old approach showed "..." if text was cut off.
New:
image

Old: had a '...' at the end of text
image

@ekraffmiller
Copy link
Contributor Author

@ChengShi-1 I replaced the ellipsis with fade, let me know what you think :)

@ekraffmiller ekraffmiller removed their assignment Jan 9, 2026
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
The fix works well in Safari
image

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Jan 9, 2026
@ChengShi-1 ChengShi-1 removed their assignment Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working FY26 Sprint 10 FY26 Sprint 10 (2025-11-05 - 2025-11-19) FY26 Sprint 11 FY26 Sprint 11 (2025-11-20 - 2025-12-03) FY26 Sprint 12 FY26 Sprint 12 (2025-12-03 - 2025-12-17) FY26 Sprint 13 FY26 Sprint 13 (2025-12-17 - 2025-12-31) FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) GREI Re-arch GREI re-architecture-related

Projects

Status: Ready for QA ⏩

Development

Successfully merging this pull request may close these issues.

Featured Item not displayed properly in Safari

4 participants