-
Notifications
You must be signed in to change notification settings - Fork 532
github actions from v3 to v4 #10997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+16
−16
Merged
github actions from v3 to v4 #10997
Changes from 5 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c094c8a
github actions from v3 to v4
stevenwinship 12c1597
Modify test file to force workflow to build and test DO NOT MERGEgit …
stevenwinship 570d128
Modify test file to force workflow to build and test DO NOT MERGE
stevenwinship 534ecdc
Modify test file to force workflow to build and test DO NOT MERGE
stevenwinship 5f19030
Modify test file to force workflow to build and test DO NOT MERGE
stevenwinship caa8bde
Modify test file to force workflow to build and test DO NOT MERGE
stevenwinship 25d0cac
Modify test file to force workflow to build and test DO NOT MERGE
stevenwinship 74fe482
Modify test file to force workflow to build and test DO NOT MERGE
stevenwinship ccee96a
Modify test file to force workflow to build and test DO NOT MERGE
stevenwinship 9263b8a
Modify test file to force workflow to build and test DO NOT MERGE
stevenwinship d719dde
remove test file
stevenwinship 37f44b5
remove test file
stevenwinship a094d81
remove test file
stevenwinship 0d8db78
Merge branch 'develop' into 10993-stop-using-action-v3
stevenwinship 6911246
Merge branch 'develop' into 10993-stop-using-action-v3
stevenwinship 9367eb1
add comment to yml files as to reason for v4.1.7
stevenwinship a426101
revert v4.1.7 to v4 (latest)
stevenwinship File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,7 @@ COPY_FIELDS="" | |
| TRIGGER_CHAIN=0 | ||
| ED_DELETE_FIELDS="'a+,'b-d" | ||
| ED_DELETE_COPYFIELDS="'a+,'b-d" | ||
| FAKEDONOTMERGE=0 | ||
|
||
|
|
||
| SOLR_SCHEMA_FIELD_BEGIN_MARK="SCHEMA-FIELDS::BEGIN" | ||
| SOLR_SCHEMA_FIELD_END_MARK="SCHEMA-FIELDS::END" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why "upload artifact" is set to "v4" but "download-artifact" is a specific version (v4.1.7)? Should we put a comment above the 4.1.7 lines to explain why it's pinned so specifically?
There's one case here and two more in the other file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in an issue that there was a bug in download V4 that was fixed in 4.1.7 actions/upload-artifact#478
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also discussion at IQSS/dataverse-frontend#550 (comment)