Skip to content

Conversation

@qqmyers
Copy link
Member

@qqmyers qqmyers commented Feb 15, 2025

What this PR does / why we need it: This PR extends the External/Curation Status Label mechanism:

  • adding tracking of who creates the status label and when,
  • keeping a history of past statuses
  • updating the CSV report to include the creation time and assigner of a status
  • updating the getCurationStatus api call to return a JSON object for the status with label, assigner, and create time
  • adding an includeHistory query param for these API calls to allow seeing prior statuses
  • adding a facet to allow filtering by curation status (for users able to set them)
  • adding the creation time to solr as a pdate to support search by time period, e.g. current status set prior to a give date
  • standardizing the language around 'curation status' vs 'external status'
  • adding a 'curation-status' class to displayed labels to allow styling
  • fixing a bug in the notification display that would show the current status rather than the status as of the notification time
  • improving the email message to include a link to the dataset and the name of/link to the collection its in.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this: Verify that curation statuses can be set/removed when the overall curation status mechanism is enabled. Verify that the status can be removed. Verify that status is removed at publication. Verify that the /api/datasets/{id}//curationStatus and /api/datasets/{id}/listCurationStates api calls return correct results, with and without the ?includeHistory=true flag. (Most of this is tested in IT tests as well.)

Does this PR introduce a user interface change? If mockups are available, please link/include them here: New facet:
image

Is there a release notes update needed for this change?:

Additional documentation:

@pdurbin pdurbin moved this to Ready for Triage in IQSS Dataverse Project Jun 2, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for Triage to Ready for Review ⏩ in IQSS Dataverse Project Jun 3, 2025
@cmbz cmbz added the FY25 Sprint 25 FY25 Sprint 25 (2025-06-04 - 2025-06-18) label Jun 4, 2025
@stevenwinship stevenwinship self-assigned this Jun 16, 2025
@stevenwinship stevenwinship moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Jun 16, 2025
@cmbz cmbz added the FY25 Sprint 26 FY25 Sprint 26 (2025-06-18 - 2025-07-02) label Jun 19, 2025
@qqmyers qqmyers removed their assignment Jun 20, 2025
@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Jun 20, 2025
@stevenwinship stevenwinship removed their assignment Jun 20, 2025
@ofahimIQSS ofahimIQSS self-assigned this Jun 23, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Jun 23, 2025
@ofahimIQSS
Copy link
Contributor

Can we update this PR with latest from dev?

IQSS/9247-CurationStatus_updates
@ofahimIQSS
Copy link
Contributor

Looking good from my end, will do further testing during release regression. Merging:
image

@ofahimIQSS ofahimIQSS merged commit a9872c9 into IQSS:develop Jun 26, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Jun 26, 2025
@ofahimIQSS ofahimIQSS removed their assignment Jun 26, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Jun 26, 2025
ofahimIQSS added a commit that referenced this pull request Jun 26, 2025
@pdurbin pdurbin mentioned this pull request Jun 26, 2025
@cmbz cmbz added the FY26 Sprint 1 FY26 Sprint 1 (2025-07-02 - 2025-07-16) label Jul 2, 2025
@cmbz cmbz added the FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) label Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 25 FY25 Sprint 25 (2025-06-04 - 2025-06-18) FY25 Sprint 26 FY25 Sprint 26 (2025-06-18 - 2025-07-02) FY26 Sprint 1 FY26 Sprint 1 (2025-07-02 - 2025-07-16) FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) GDCC: QDR of interest to QDR Size: 10 A percentage of a sprint. 7 hours.

Projects

Status: Done 🧹

5 participants