Skip to content

Conversation

@poikilotherm
Copy link
Contributor

What this PR does / why we need it:
Without pinning down the port, sometimes Testcontainers thinks it should apply the waiting strategy on the SMTP port. Telling it explicitely which port to use fixes this.

Which issue(s) this PR closes:

Special notes for your reviewer:
None

Suggestions on how to test this:
Watch the integration tests not fail in CI

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope

Is there a release notes update needed for this change?:
Nope

Additional documentation:
Nope

…1472

Without pinning down the port, sometimes Testcontainers thinks it should
apply the waiting strategy on the SMTP port. Telling it explicitely
which port to use fixes this.
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a good fix

@github-project-automation github-project-automation bot moved this to Ready for QA ⏩ in IQSS Dataverse Project May 8, 2025
Copy link
Contributor

@ofahimIQSS ofahimIQSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@ofahimIQSS ofahimIQSS self-assigned this May 8, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project May 8, 2025
@ofahimIQSS
Copy link
Contributor

Integration tests passing - merging.

@ofahimIQSS ofahimIQSS merged commit 43547e7 into IQSS:develop May 8, 2025
16 of 17 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project May 8, 2025
@ofahimIQSS ofahimIQSS removed their assignment May 8, 2025
@pdurbin pdurbin added this to the 6.7 milestone May 8, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Code Infrastructure formerly "Feature: Code Infrastructure" Feature: Performance & Stability Size: 0.5 A percentage of a sprint. 0.35 hours

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

MailServiceBeanIT Failing Due to dockage/mailcatcher:latest Container Startup Error in CI

3 participants