Skip to content

MakeDataCount API may end up in infinite loop #11535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofahimIQSS merged 2 commits into from
Jul 23, 2025
Merged

MakeDataCount API may end up in infinite loop #11535

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2faca62
MakeDataCount MDC API - Adding disconnect() on HttpURLConnection in c…
luddaniel May 28, 2025
d188361
MakeDataCount MDC API - Use cursor method for pagination to fix infi…
luddaniel May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/edu/harvard/iq/dataverse/api/MakeDataCountApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ public Response updateCitationsForDataset(@PathParam("id") String id) throws IOE
url = new URI(JvmSettings.DATACITE_REST_API_URL.lookup(pidProvider.getId()) +
"/events?doi=" +
authorityPlusIdentifier +
"&source=crossref&page[size]=1000").toURL();
"&source=crossref&page[size]=1000&page[cursor]=1").toURL();
} catch (URISyntaxException e) {
//Nominally this means a config error/ bad DATACITE_REST_API_URL for this provider
logger.warning("Unable to create URL for " + persistentId + ", pidProvider " + pidProvider.getId());
Expand All @@ -175,11 +175,14 @@ public Response updateCitationsForDataset(@PathParam("id") String id) throws IOE
int status = connection.getResponseCode();
if (status != 200) {
logger.warning("Failed to get citations from " + url.toString());
connection.disconnect();
return error(Status.fromStatusCode(status), "Failed to get citations from " + url.toString());
}
JsonObject report;
try (InputStream inStream = connection.getInputStream()) {
report = JsonUtil.getJsonObject(inStream);
} finally {
connection.disconnect();
}
JsonObject links = report.getJsonObject("links");
JsonArray data = report.getJsonArray("data");
Expand Down