update dvObject featured item response #11552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
GREI Re-arch
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
stevenwinship
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
This comment has been minimized.
This comment has been minimized.
Contributor
|
@stevenwinship were you able to see what was going on with the following:
|
This comment has been minimized.
This comment has been minimized.
Contributor
|
Thanks @stevenwinship things are now working as expected after testing with Postman 👍🏼 |
This comment has been minimized.
This comment has been minimized.
stevenwinship
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS Dataverse Project
GPortas
reviewed
Jun 9, 2025
Contributor
GPortas
left a comment
GPortas
left a comment
There was a problem hiding this comment.
This looks good overall. I’ve just left a couple of small suggestions.
src/main/java/edu/harvard/iq/dataverse/util/json/JsonPrinter.java
Outdated
Show resolved
Hide resolved
src/test/java/edu/harvard/iq/dataverse/api/DataverseFeaturedItemsIT.java
Show resolved
Hide resolved
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
This comment has been minimized.
This comment has been minimized.
Contributor
|
Hi @stevenwinship, @ChengShi-1 pointed out another issue that I believe is a bug. It appears the API is allowing us to feature a file from a dataset that hasn't been published yet. |
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
stevenwinship
moved this from In Progress 💻
to Ready for QA ⏩
in IQSS Dataverse Project
g-saracca
reviewed
Jun 19, 2025
src/main/java/edu/harvard/iq/dataverse/dataverse/featured/DataverseFeaturedItem.java
Show resolved
Hide resolved
Contributor
|
looks good to me, merging |
github-project-automation
bot
moved this from Ready for QA ⏩
to Merged 🚀
in IQSS Dataverse Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: For the SPA, we need the specific Dataverse object identifiers. This could be the collection alias, the full DOI of a dataset, or a file ID.
Which issue(s) this PR closes:#11550
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: Included
Additional documentation: