#11546 fix compare separator logic

[sekmiller]

What this PR does / why we need it: Publishing was failing when separator was empty and didn't match the default separator

Which issue(s) this PR closes:

• Closes Publication fails with file PIDs enabled for some files #11546

Special notes for your reviewer:

Suggestions on how to test this: create files with file PIDs disabled then enable file PIDs (curl -X PUT -d 'true' http://localhost:8080/api/admin/settings/:FilePIDsEnabled) you should be able to publish and get file PIDs assigned.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

[github-actions]

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11546-pid-separator

ghcr.io/gdcc/configbaker:11546-pid-separator

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

[pdurbin]

In the interest of keeping things moving I'm approving this. I didn't test it but the code looks ok to me. Also, API tests are passing.

@sekmiller did you check with @qqmyers about this fix? When he briefly went over #11546 during Triage Tuesday the other day, I was under the impression that he expected we'd need to add a Flyway script. I clicked "request review" from him, at least. 🤷

[sekmiller]

The Flyway script would have been a bandaid and would not help in the case where files are created while file PIDs are not enabled, and an attempt was made to publish after file PIDs were enabled

[ofahimIQSS]

fix looks good. Merging.