Add optional logging of requests for non-existent/non-public PIDs #11601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmbz
added
FY26 Sprint 4
pdurbin
reviewed
Sep 3, 2025
|
|
||
|
|
||
| ; | ||
|
|
Member
There was a problem hiding this comment.
I'm just adding this at the end...
https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-11601/3/testReport/junit/edu.harvard.iq.dataverse.api/DataverseFeaturedItemsIT/testCreateFeaturedItemWithBadDvOdbjectIds/ is failing with a 500 error. Can you please merge the latest from develop and see if tests pass?
pdurbin
reviewed
Sep 4, 2025
pdurbin
reviewed
Sep 4, 2025
pdurbin
approved these changes
Sep 8, 2025
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
I haven't tested this PR myself but I'm approving it because I think it's ready for manual testing.
@ofahimIQSS please don't merge until the Jenkins issues you identified have been resolved:
This PR is failing with this one:
TASK [dataverse : download and unzip solr] *************************************
client_loop: send disconnect: Broken pipe
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
looks good, merging |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: When users share PIDs from draft datasets/files or share a URL to a dataset/file page with issues such as a trailing '.' character, they get a 404 response but there is no easy way for admins to track these cases. This PR adds a capability to log such failure, optionally enabled by a new Feature Flag, that collects these events. The result can be used with the pidreport.py Python script at gdcc/dataverse-recipes#26 and cron to send monthly alerts to Dataverse admins/curators.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: Turn the flag on, request some non-existent datasets/files by PID using the JSF interface and/or API and verify that you see a new PIDFailures_.log file recording those failures.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: