Fix ct image releasing

[poikilotherm]

What this PR does / why we need it:

Add another build trigger for base images in case there is no "r0" tag on the hub, the base image needs no updates, but we're maintaining a release.

Which issue(s) this PR closes:

• Closes 6.7 app image tag wasn't created on release #11659
• Closes "latest" tag and revision tag (e.g. 6.7-noble-r0) were not created on Docker Hub for 6.7 app image #11661
• Closes "latest" tag was not created on Docker Hub for 6.7 base image #11662

Special notes for your reviewer:
None

Suggestions on how to test this:
Copy the added bits into a separate test script at .github/workflows/scripts/containers/test.sh:

#!/usr/bin/bash

BASE_IMAGE_REF="gdcc/base:6.8-noble"
IS_DEV=0

source "$( dirname "$0" )/utils.sh"
REV=$( current_revision "$BASE_IMAGE_REF" )

IS_NEW_RELEASE=0
if ! (( IS_DEV )) && [ "$REV" = "-1" ]; then
  echo "This is a newly released version of Dataverse - forcing build, as no r0 image is present on Docker Hub"
  IS_NEW_RELEASE=1
fi

echo "is_new_release: ${IS_NEW_RELEASE}"

Running the script should print:

This is a newly released version of Dataverse - forcing build, as no r0 image is present on Docker Hub
is_new_release: 1

Changing IS_DEV=1 or changing the BASE_IMAGE_REF to point to e.g. 6.6-noble should print is_new_release=0.

Also, please run the maintenance script locally and in DRY_RUN mode and watch for the tag options to be added correctly. You should also run a DAMP_RUN and see if the build log contains the additional tags (the docker build statement should carry them!)

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope.

Is there a release notes update needed for this change?:
Nope.

Additional documentation:
None.

[pdurbin]

Looks like it should do the trick! Thanks, @poikilotherm!

[pdurbin]

As discussed at https://dataverse.zulipchat.com/#narrow/channel/375812-containers/topic/6.2E7.20release/near/529904650 @poikilotherm is thinking about using this PR to close multiple issues:

• 6.7 app image tag wasn't created on release #11659
• "latest" tag and revision tag (e.g. 6.7-noble-r0) were not created on Docker Hub for 6.7 app image #11661
• "latest" tag was not created on Docker Hub for 6.7 base image #11662

So I'm pulling it out of "ready for QA" to give him time. Thanks, Oliver! ❤️

[poikilotherm]

@pdurbin this should be done. Tested it locally. Please try it yourself as well. Thx!

[coveralls]

coverage: 23.186% (+0.004%) from 23.182%
when pulling af9d096 on 11659-fix-ct-release
into 74b3bc7 on develop.

[pdurbin]

This all looks reasonable to me. Approved. Thanks, @poikilotherm! ❤️

[poikilotherm]

@pdurbin @ofahimIQSS we shall run the maintenance action once merged. Thx!

[github-actions]

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11659-fix-ct-release

ghcr.io/gdcc/configbaker:11659-fix-ct-release

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

[poikilotherm]

As per discussion on Zulip, I am going ahead and push the button on this one. Not including it in 6.8 means adding another backport and no proper images at release time. If things go sideways, blame it on the remote guy.

Scene from Igor movie