-
Notifications
You must be signed in to change notification settings - Fork 532
11710 find dataverses for linking #11741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Contributor
|
11710server.log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FY26 Sprint 4
FY26 Sprint 4 (2025-08-13 - 2025-08-27)
FY26 Sprint 5
FY26 Sprint 5 (2025-08-27 - 2025-09-10)
FY26 Sprint 6
FY26 Sprint 6 (2025-09-10 - 2025-09-24)
FY26 Sprint 7
FY26 Sprint 7 (2025-09-24 - 2025-10-08)
FY26 Sprint 8
FY26 Sprint 8 (2025-10-08 - 2025-10-22)
Original size: 30
Size: 10
A percentage of a sprint. 7 hours.
SPA.Q3.2025.4
Link Dataset
SPA
These changes are required for the Dataverse SPA
Type: Feature
a feature request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Adds a new api endpoint which may be used to retrieve a list of Dataverse Collections to which a given Dataset or Dataverse Collection may be linked. The end point also takes in a search term which currently must be the start of the collections' names.
Which issue(s) this PR closes:
Special notes for your reviewer:
One piece of new functionality is adding a search feature to the query on permissions - so that you can pass a search term along with a user and permission to further filter the collections returned.
The also fixes an unrelated test for retrieving a Dataverse Collection's Templates. In an existing database if there are templates created in Root then those templates will be inherited by any collection that is a child of Root that also shares Root's metadata blocks.Since the test asserts that only the newly created template should be available to the collection the inherited template causes a failure. I updated the test so that the child dataverse will have different metadata blocks than Root so that the only template available is the one created in the child as assumed by the test.
Also changed the name of findDvoByIdAndFeaturedItemTypeOrDie since I used it here and it really doesn't depend on the dvObject being a featured item.
Also added a new json object builder for dataverses which only returns the id, alias and name of the dataverse, this was needed to return the response suggested in the ticket.
Suggestions on how to test this: Try the new api endpoints and verify that the expected collections are returned.
-The end point also takes in an optional search term which is tested against the collections' names.
-The user calling this API must have Link Dataset or Link Dataverse permission on the Dataverse Collections returned and given the object type.
-there is also a queryParam for "alreadyLinked" which returns a list of dataverses to which the queried dvObject (either dataset or dataverse) is linked, to be used for unlinking. (Only those collections that the requester has linking permissions will be returned.
-If the Collection has already been linked to the given Dataset or Collection, it will not be returned.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
-included
Additional documentation:
docs added under native api