Skip to content

Conversation

@sekmiller
Copy link
Contributor

What this PR does / why we need it: fixes input level so that previously entered custom values are not wiped out of the api is used again with other dataset field types being given custom values. the only way to remove a custom value for input levels in a given dataverse is to pass in an empty array for input levels or explicitly re-setting them via the api with a json array that has the default values.

Which issue(s) this PR closes:

Special notes for your reviewer:
When running the integration tests (DataversesIT#testUpdateInputLevels) I noticed an error in the log saying that the command was receiving an empty or null input level array. This error was also present in the previous version of the test and doesn't prevent them from passing.
dev_dataverse> Error while executing command edu.harvard.iq.dataverse.engine.command.impl.UpdateDataverseInputLevelsCommand@14fb88b8
dev_dataverse> edu.harvard.iq.dataverse.engine.command.exception.CommandException: Error while updating dataverse input levels: Input level list cannot be null or empty
dev_dataverse> at edu.harvard.iq.dataverse.engine.command.impl.UpdateDataverseInputLevelsCommand.execute(UpdateDataverseInputLevelsCommand.java:30)
dev_dataverse> at edu.harvard.iq.dataverse.engine.command.impl.UpdateDataverseInputLevelsCommand.execute(UpdateDataverseInputLevelsCommand.java:16)
Suggestions on how to test this:
Run the input level update api several times and make sure that previous values are not deleted unless explicitly included in the api (or an empty array is passed)

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
no
Additional documentation:
none

@github-actions github-actions bot added FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) Size: 10 A percentage of a sprint. 7 hours. Type: Bug a defect labels Aug 15, 2025
@sekmiller sekmiller moved this to Ready for QA ⏩ in IQSS Dataverse Project Aug 15, 2025
@sekmiller sekmiller added this to the 6.8 milestone Aug 15, 2025
@coveralls
Copy link

coveralls commented Aug 15, 2025

Coverage Status

coverage: 23.544% (+0.003%) from 23.541%
when pulling 6512eb3 on 11387-fix-inputLevel-api
into 08b9ec6 on develop.

@sekmiller sekmiller moved this from Ready for QA ⏩ to Ready for Review ⏩ in IQSS Dataverse Project Aug 15, 2025
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Sep 10, 2025
@github-actions

This comment has been minimized.

@ofahimIQSS ofahimIQSS self-assigned this Sep 11, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Sep 11, 2025
@pdurbin pdurbin modified the milestones: 6.8, 6.9 Sep 12, 2025
@pdurbin pdurbin moved this from QA ✅ to In Review 🔎 in IQSS Dataverse Project Sep 12, 2025
@cmbz cmbz added the FY26 Sprint 6 FY26 Sprint 6 (2025-09-10 - 2025-09-24) label Sep 14, 2025
@ofahimIQSS ofahimIQSS removed their assignment Sep 16, 2025
@scolapasta scolapasta moved this from In Review 🔎 to Reviewed but Frozen ❄️ in IQSS Dataverse Project Sep 16, 2025
@cmbz cmbz added the FY26 Sprint 7 FY26 Sprint 7 (2025-09-24 - 2025-10-08) label Sep 24, 2025
@sekmiller sekmiller moved this from Reviewed but behind develop ⬅️ to Ready for QA ⏩ in IQSS Dataverse Project Sep 26, 2025
@github-actions

This comment has been minimized.

@ofahimIQSS
Copy link
Contributor

looks like continuous integration is failing on this one

@github-actions

This comment has been minimized.

@sekmiller
Copy link
Contributor Author

All checks passing now

@ofahimIQSS ofahimIQSS self-assigned this Sep 30, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Sep 30, 2025
@github-actions
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11387-fix-inputLevel-api
ghcr.io/gdcc/configbaker:11387-fix-inputLevel-api

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@ofahimIQSS
Copy link
Contributor

very nice - tests passing - merging

@ofahimIQSS ofahimIQSS merged commit d9d6903 into develop Sep 30, 2025
21 checks passed
@ofahimIQSS ofahimIQSS deleted the 11387-fix-inputLevel-api branch September 30, 2025 21:59
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Sep 30, 2025
@ofahimIQSS ofahimIQSS removed their assignment Sep 30, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) FY26 Sprint 5 FY26 Sprint 5 (2025-08-27 - 2025-09-10) FY26 Sprint 6 FY26 Sprint 6 (2025-09-10 - 2025-09-24) FY26 Sprint 7 FY26 Sprint 7 (2025-09-24 - 2025-10-08) Size: 10 A percentage of a sprint. 7 hours. Type: Bug a defect

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Input Level API overwrites existing displayOnCreate settings

7 participants