-
Notifications
You must be signed in to change notification settings - Fork 531
11387 fix input level api #11748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
11387 fix input level api #11748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
looks like continuous integration is failing on this one |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
All checks passing now |
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Contributor
|
very nice - tests passing - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FY26 Sprint 4
FY26 Sprint 4 (2025-08-13 - 2025-08-27)
FY26 Sprint 5
FY26 Sprint 5 (2025-08-27 - 2025-09-10)
FY26 Sprint 6
FY26 Sprint 6 (2025-09-10 - 2025-09-24)
FY26 Sprint 7
FY26 Sprint 7 (2025-09-24 - 2025-10-08)
Size: 10
A percentage of a sprint. 7 hours.
Type: Bug
a defect
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: fixes input level so that previously entered custom values are not wiped out of the api is used again with other dataset field types being given custom values. the only way to remove a custom value for input levels in a given dataverse is to pass in an empty array for input levels or explicitly re-setting them via the api with a json array that has the default values.
Which issue(s) this PR closes:
Special notes for your reviewer:
When running the integration tests (DataversesIT#testUpdateInputLevels) I noticed an error in the log saying that the command was receiving an empty or null input level array. This error was also present in the previous version of the test and doesn't prevent them from passing.
dev_dataverse> Error while executing command edu.harvard.iq.dataverse.engine.command.impl.UpdateDataverseInputLevelsCommand@14fb88b8
dev_dataverse> edu.harvard.iq.dataverse.engine.command.exception.CommandException: Error while updating dataverse input levels: Input level list cannot be null or empty
dev_dataverse> at edu.harvard.iq.dataverse.engine.command.impl.UpdateDataverseInputLevelsCommand.execute(UpdateDataverseInputLevelsCommand.java:30)
dev_dataverse> at edu.harvard.iq.dataverse.engine.command.impl.UpdateDataverseInputLevelsCommand.execute(UpdateDataverseInputLevelsCommand.java:16)
Suggestions on how to test this:
Run the input level update api several times and make sure that previous values are not deleted unless explicitly included in the api (or an empty array is passed)
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
no
Additional documentation:
none