-
Notifications
You must be signed in to change notification settings - Fork 531
6.8 release notes #11816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6.8 release notes #11816
Conversation
|
Hey @pdurbin. Should the Search API's new datasetCount param also be documented in the Search API Guides? I see the new show_collections param in the Parameters table in the v6.8 Search API Guide, at https://github.com/IQSS/dataverse/blob/11674-6.8-release-notes/doc/sphinx-guides/source/api/search.rst, but I don't see the datasetCount param listed there or mentioned anywhere in that guide. Also, I couldn't get the datasetCount param to work on https://qa.dataverse.org. I tried https://qa.dataverse.org/api/search?q=*&type=dataverse&datasetCount:[1000%20TO%20*], which I think means "Return collections that have 1000 or more datasets", but the results seem to include all collections, like the datasetCount param is being ignored. Am I using this param the right way? |
Co-authored-by: Omer Fahim <[email protected]>
|
@jggautier great question. Generally speaking we don't document search fields, but we made an exception for dateSort in #6264: https://guides.dataverse.org/en/6.7.1/api/search.html#date-range-search-example We probably should document search fields. One challenge is that a lot of them are dynamic since they come from metadata blocks, but there are plenty that are hard-coded, like If you or anyone reading this wants to create an issue about documenting the search fields, I do think we should do it some time. Or maybe we add an API that returns them? 🤔 We should make them discoverable somehow. When I need I reminder I go to SearchFields.java or the Solr schema. |
This reverts commit 7c98189.
|
|
||
| Upgrading requires a maintenance window and downtime. Please plan accordingly, create backups of your database, etc. | ||
|
|
||
| These instructions assume that you've already upgraded through all the 5.x releases and are now running Dataverse 6.6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be Dataverse 6.7.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, thanks. Good catch. Fixed in 56ede77.
sekmiller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only found one minor typo, but I will leave it open for now so that others may have the opportunity to weigh in
|
|
||
| - Start Solr instance (usually `service solr start` depending on Solr/OS). | ||
|
|
||
| 7\. Reindex Solr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the new datasetCount field the only reason we are suggesting a reindex?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still debating if it's worth mentioning. It's kind of criminal to tell someone with a database the size of ours to reindex everything (a monumental task) when it's only the collections that need to be reindexed. But then there are few if any instances the size of ours.
But I feel like it could be a good practice to always tell people why a reindex is on the checklist. Just so that an instance can decide if that's something they need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under step 6 it already say this:
Due to changes in the Solr schema (the addition of field "datasetCount"), updating the Solr schema and reindexing is required.
Is that sufficient? Or do you think we should say this again under step 7 about reindexing?
I could even combine steps 6 and 7 into a single step if that makes more sense.
ofahimIQSS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed Release notes - Approving from my side.
update to step 6 Co-authored-by: Philip Durbin <[email protected]>
ofahimIQSS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved changes
What this PR does / why we need it:
Release notes for 6.8.
You can preview them here: https://github.com/IQSS/dataverse/blob/11674-6.8-release-notes/doc/release-notes/6.8-release-notes.md
Which issue(s) this PR closes:
Special notes for your reviewer:
I'm not aware of any security updates so I removed that section.Nevermind. As @qqmyers pointed out, we updated a number of dependencies in this release. I put the security section back in.