Skip to content

fix/upload-artifacts#42

Merged
TjazVracko merged 1 commit intomainfrom
fix/upload-artifacts-1
May 20, 2025
Merged

fix/upload-artifacts#42
TjazVracko merged 1 commit intomainfrom
fix/upload-artifacts-1

Conversation

@TjazVracko
Copy link
Contributor

@TjazVracko TjazVracko commented May 20, 2025

Description

You forgot to replace artefacts -> artifacts here, so nothing was added to a release.

Areas of interest for the reviewer

Checklist

  • My code follows the style guidelines as defined by IRNAS.
  • I have performed a self-review of my code.
  • My changes generate no new warnings.
  • I added/updated source code documentation for all newly added or changed functions.
  • I updated all customer-facing technical documentation. - This PR
    introduced only internal facing changes.

After-review steps

  • I will merge PR by myself.

@TjazVracko TjazVracko requested a review from MarkoSagadin May 20, 2025 08:07
@github-actions github-actions bot added the fix label May 20, 2025
Change `artefacts` -> `artifacts`, so that the artifacts are uploaded
correctly in the release workflow.
@TjazVracko TjazVracko force-pushed the fix/upload-artifacts-1 branch from cca00ff to e4b3637 Compare May 20, 2025 09:12
@MarkoSagadin
Copy link
Collaborator

Good catch.

Can you also check the same file in the following repos/locations if this is done correctly?:

irnas-workflows-software:

  • .github/workflows
  • workflow_template/zephyr/.github/workflows
  • workflow_template/basic/.github/workflows

irnas-project-template:

  • .github/workflows

Copy link
Contributor Author

TjazVracko commented May 20, 2025

Merge activity

  • May 20, 8:21 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • May 20, 8:22 AM EDT: @TjazVracko merged this pull request with Graphite.

@TjazVracko TjazVracko merged commit beef261 into main May 20, 2025
2 checks passed
@TjazVracko TjazVracko deleted the fix/upload-artifacts-1 branch June 24, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants