[Fix] Fix overgeneralizaiton of var to varlist #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This PR reverts a fix in PR #77 that caused overgeneralization of vars to varlists, and instead fixes the root issue of a regex typo in fingerprinting that caused a variable to be infinitely generalized. It also fixes a minor regex issue in
unify_variable_namesthat caused the<=sign in<x1> > <x2> AND <x1> <= <x2>to be seen as part of a variable.Testing:
testtest_generate_general_rule_8and fixestest_generate_spreadsheet_id_4testsIssues:
close #80