Skip to content

Conversation

@colinthebomb1
Copy link
Collaborator

Overview:

This PR reverts a fix in PR #77 that caused overgeneralization of vars to varlists, and instead fixes the root issue of a regex typo in fingerprinting that caused a variable to be infinitely generalized. It also fixes a minor regex issue in unify_variable_names that caused the <= sign in <x1> > <x2> AND <x1> <= <x2> to be seen as part of a variable.

Testing:

  • Pass all existing tests under test
  • Reintroduce test_generate_general_rule_8 and fixes test_generate_spreadsheet_id_4 tests

Issues:

close #80

@colinthebomb1 colinthebomb1 self-assigned this Oct 6, 2025
@colinthebomb1 colinthebomb1 merged commit cd919be into main Oct 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [BE] VarSQL variables will sometimes be overgeneralized into varlists

3 participants