Skip to content

Conversation

@rerpha
Copy link
Contributor

@rerpha rerpha commented Feb 12, 2025

Description of work

Add your own description here

To test

Which ticket does this PR fix?

Acceptance criteria

List the acceptance criteria for the PR


Code Review

  • Is the code of an acceptable quality?
  • Are there unit tests in place? Are the unit tests small and test the a class in isolation?
  • Have the changes been documented in the release notes. If so, do they describe the changes appropriately?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed.
  • How do the changes handle unexpected situations, e.g. bad input?
  • Has developer documentation been updated if required?

@rerpha rerpha marked this pull request as ready for review February 12, 2025 09:43
Tom-Willemsen
Tom-Willemsen previously approved these changes Feb 12, 2025
@rerpha rerpha requested a review from Tom-Willemsen February 14, 2025 11:55
@rerpha rerpha changed the title conditionally set MAX_ARRAY_BYTES if not already set remove setting MAX_ARRAY_BYTES Feb 17, 2025
@FreddieAkeroyd FreddieAkeroyd merged commit 925f743 into main Feb 20, 2025
11 checks passed
@FreddieAkeroyd FreddieAkeroyd deleted the rerpha-patch-1 branch February 20, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants