Skip to content

Conversation

@Tom-Willemsen
Copy link
Member

@Tom-Willemsen Tom-Willemsen commented Feb 12, 2025

By giving it a parent, which is the module in which the ScanningInstrument class was defined

Description of work

Fixes an error of the form astroid.exceptions.ParentMissingError: Parent not found on <NodeNG ...>

To test

Which ticket does this PR fix?

Acceptance criteria

List the acceptance criteria for the PR


Code Review

  • Is the code of an acceptable quality?
  • Are there unit tests in place? Are the unit tests small and test the a class in isolation?
  • Have the changes been documented in the release notes. If so, do they describe the changes appropriately?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed.
  • How do the changes handle unexpected situations, e.g. bad input?
  • Has developer documentation been updated if required?

By giving it a parent, which is the module in which the ScanningInstrument class was defined
@Tom-Willemsen
Copy link
Member Author

Tom-Willemsen commented Feb 12, 2025

Verified by pip installing this commit on LARMOR.

Once this is merged, make a proper point-release out of it, and then deploy that to larmor instead. Also deploy to other instruments which use the old scans library (sans+reflectometers). Can be done as an ssh backdoor pip upgrade

@KathrynBaker KathrynBaker merged commit c4c5871 into main Feb 13, 2025
11 checks passed
@KathrynBaker KathrynBaker deleted the fix_astroid_crash branch February 13, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants