Skip to content

Conversation

@Tom-Willemsen
Copy link
Member

@Tom-Willemsen Tom-Willemsen commented Feb 20, 2025

Description of work

To test

Fixes #24

Acceptance criteria

With DBSVR running:

  • g.begin() should not change meas_id / sample_id / sample_subid / meas_type
  • g.begin(sample_id="toms_fave_sample") should change sample id and then begin
    • Similar for meas_id / meas_subid / meas_type
    • Check this in "experiment details" perspective

Without DBSVR running:

  • g.begin() should begin a run without error
  • g.begin(sample_id="toms_fave_sample") should stall with CA errors as we've explicitly asked to change a parameter but DBSVR is unreachable so that can't be done
    • Similar for meas_id / meas_subid / meas_type

Code Review

  • Is the code of an acceptable quality?
  • Are there unit tests in place? Are the unit tests small and test the a class in isolation?
  • Have the changes been documented in the release notes. If so, do they describe the changes appropriately?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed.
  • How do the changes handle unexpected situations, e.g. bad input?
  • Has developer documentation been updated if required?

rerpha
rerpha previously approved these changes Feb 20, 2025
@rerpha rerpha merged commit 639ab86 into main Sep 15, 2025
15 checks passed
@rerpha rerpha deleted the 24 branch September 15, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

g.begin() should work even if DBSVR is unreachable

5 participants