Change autosave frequency command #52
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 1, 2025 11:18
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
added 12 commits
July 3, 2025 13:13
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
1 task
Member
|
In the ticket it said:
But this looks to be using the XML route - did you discuss this with Freddie? |
| </U32> | ||
| </Cluster> | ||
| """ | ||
|
|
Member
There was a problem hiding this comment.
You should use the full XML herer as per https://github.com/ISISComputingGroup/EPICS-isisdae/blob/master/isisdaeApp/src/xml/update_settings_cluster.xml
| Args: | ||
| freq (float): frequency of autosave in Hz. | ||
| """ |
Member
There was a problem hiding this comment.
The units are actually "Frames" (as in isis pulses) as opposed to Hz and are an integer
| func = self.api.set_pv_value | ||
|
|
||
| check_xml = ( | ||
| b"<Cluster>\n <Name>DAE Updates</Name>\n <NumElts>3</NumElts>\n" |
Member
There was a problem hiding this comment.
rather than repeat the xml data structure, could you make UPDATE_SETTINGS_XML a template i.e. with placeholders for data and then use that both here and earlier?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a change ICP autosave frequency command.
DAE:UPDATESETTINGSpvPVValuecan now be of subtypeBytesTo test: