Skip to content

Conversation

@rerpha
Copy link
Contributor

@rerpha rerpha commented Oct 14, 2025

Description of work

By making it less clever. evidently this is also less lines of code...

To test

See ISISComputingGroup/IBEX#8849

Acceptance criteria

see ticket.


Code Review

  • Is the code of an acceptable quality?
  • Are there unit tests in place? Are the unit tests small and test the a class in isolation?
  • Have the changes been documented in the release notes. If so, do they describe the changes appropriately?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed.
  • How do the changes handle unexpected situations, e.g. bad input?
  • Has developer documentation been updated if required?

change_period(params[k])
elif key == "nperiods":
change_number_soft_periods(params[k])
elif key == "user" or key == "users":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ew

@rerpha rerpha force-pushed the 8849_change_command_type_checking branch from 3ba7925 to 8cd472d Compare October 14, 2025 14:04
@Tom-Willemsen Tom-Willemsen merged commit 19cdfee into main Oct 14, 2025
15 checks passed
@Tom-Willemsen Tom-Willemsen deleted the 8849_change_command_type_checking branch October 14, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants