Skip to content

Overwrite error_log_func #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rerpha merged 1 commit into from
Nov 28, 2024
Merged

Overwrite error_log_func #8

rerpha merged 1 commit into from
Nov 28, 2024

Conversation

@Tom-Willemsen
Copy link
Member

@Tom-Willemsen Tom-Willemsen commented Nov 26, 2024

Closes ISISComputingGroup/IBEX#8579

Code Review

  • Is the code of an acceptable quality?
  • Are there unit tests in place? Are the unit tests small and test the a class in isolation?
  • Have the changes been documented in the release notes. If so, do they describe the changes appropriately?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed.
  • How do the changes handle unexpected situations, e.g. bad input?
  • Has developer documentation been updated if required?

@Tom-Willemsen
Correctly overwrite error_log_func
8169994 
This is not a nice API, but doing the minimal refactor for the moment.
@Tom-Willemsen Tom-Willemsen changed the title Correctly overwrite error_log_func Overwrite error_log_func Nov 26, 2024
@rerpha rerpha merged commit 602d5cd into main Nov 28, 2024
11 checks passed
@rerpha rerpha deleted the Ticket8579 branch November 28, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rerpha rerpha rerpha approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

system tests: ca error

3 participants

@Tom-Willemsen @rerpha