Skip to content

Comments

fix exception if output file (rbnum) dir doesn't exist#98

Merged
rerpha merged 17 commits intomainfrom
fix_exception_if_dir_doesnt_exist
Feb 7, 2025
Merged

fix exception if output file (rbnum) dir doesn't exist#98
rerpha merged 17 commits intomainfrom
fix_exception_if_dir_doesnt_exist

Conversation

@rerpha
Copy link
Contributor

@rerpha rerpha commented Feb 3, 2025

this fixes an exception that occurs when the HumanReadableFileCallback tries to create a file if the parent directory does not exist.

Closes #99

@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 3, 2025
@pull-request-size pull-request-size bot added size/S and removed size/M labels Feb 4, 2025
@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 4, 2025
@rerpha rerpha requested a review from Tom-Willemsen February 4, 2025 09:16
@pull-request-size pull-request-size bot added size/L and removed size/M labels Feb 4, 2025
@rerpha rerpha mentioned this pull request Feb 4, 2025
Copy link
Member

@Tom-Willemsen Tom-Willemsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I keep adding comments but just noticed a couple more things which would be useful to sort while we're here...

@rerpha rerpha requested a review from Tom-Willemsen February 6, 2025 08:41
Tom-Willemsen
Tom-Willemsen previously approved these changes Feb 6, 2025
@rerpha rerpha merged commit 7d3e7ea into main Feb 7, 2025
15 checks passed
@rerpha rerpha deleted the fix_exception_if_dir_doesnt_exist branch February 7, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

human readable files: all fields put in rather than just measured fields

2 participants