Ticket8349 crosshair overlay #1820
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Does 200k lines of changes really meet the threshold for a flash review? |
Contributor
Author
The changes has been already reviewed and tested as part of another ticket: #1802. When I closed it reported unmerged commits, so I created a follow up PR |
Member
|
I have reopened previous PR |
Member
|
Previous PR had failing opi checker test so could not be merged, hence unmerged commits when PR closed. Will fix OPI check. |
Contributor
Author
|
I have approved the changes again but not getting the option to merge even now. It is still disabled for me. There were too many OPI test failures, all basically for a dummy widget. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committing unmerged commits