Skip to content

36 fields determine sharednt handler initialisation #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kurup merged 38 commits into from
Oct 13, 2025
Merged

36 fields determine sharednt handler initialisation #43

kurup merged 38 commits into from
Oct 13, 2025

Conversation

@Monarda
Copy link
Contributor

@Monarda Monarda commented Oct 9, 2025 •
edited
Loading

This next PR:

  • Fixes issues with the kwargs for Rules like calc not being correctly consumed.
  • Rules may now restrict the NT Type to which they apply. For example, the AlarmNTEnumRule now only applies to NTEnum types.
  • Includes an example of how to add a custom rule (examples/custom_rule/imatch_alarm.py), including how to add it to the automatically added Rules.
  • Fixes the alarmNTenum Rule to use the same kwarg initialisation pattern as the other Rules. This causes a lot of minor changes to the tests.

Monarda added 30 commits September 8, 2025 18:11
@Monarda
Monkeypatching p4p.server.cli shows other more subtle bugs
9ee48c5
@Monarda
Finish modifications to support new put Rule syntax
f5ab01e
@Monarda
Fix test to work with new put_rule syntax
cf96a6d
@Monarda
Tired of annoying TestPyPi fail email messages
9361e77
@Monarda
Rules into separate files
74270c7
@Monarda
Add handler constructors
f2ec3fa
@Monarda
Remaining changes to NTEnum tests and example
342c513
@Monarda
Merge branch '29-implement-alarm-rules-for-ntenums' into 28-monkey-pa…
46f1d7e 
…tch-servercli
@Monarda
Tidying up from ruff
ac968e1
@Monarda
Merge branch 'main' into 28-monkey-patch-servercli
05730c5
@Monarda
Add basic summayr of what the monkey patching does and why we're doin…
348d275 
…g it
@Monarda
Merge branch '28-monkey-patch-servercli' of github.com:ISISNeutronMuo…
b6ddf62 
…n/p4pillon into 28-monkey-patch-servercli
@Monarda
Merge branch '28-monkey-patch-servercli' into 36-fields-determine-sha…
0da39cf 
…rednt-handler-initialisation
@Monarda
Fixed corrupt main branch
5f9ce3f
@Monarda
Working on different import model
61fd236
@Monarda
Finish removing 'concurrency' and fix some subtle bugs
259c141
@Monarda
Add shared concurrency integration test
526ad83
@Monarda
Merge branch 'main' into 36-fields-determine-sharednt-handler-initial…
7ae8718 
…isation
@Monarda
Experiments with p4p.Type
c3408d5
@Monarda
Switch to handler config based on Type, fix tests
4653fec
@Monarda
Move NT specs into own file
ec55d86
@Monarda
Identify NT types
036a0a6
@Monarda
Timeout if error
fa61ac3
@Monarda
Test control rule for arrays
22fe1b9
@Monarda
Expose name and fields as public, experiment with types
9fc6632
@Monarda
Rename integration rules to prevent clash of names with unit tests
c02da1d
@Monarda
Revise rules to support introspection for SharedNT
7d7ac09
@Monarda
Remove obsolete code
67c0c1a
@Monarda
Simple test to see if a Type is an array
b3a3b05
@Monarda
Use Rule introspection to automatically setup Handlers
5cc0ab4
@Monarda Monarda requested review from aqshafei and kurup October 9, 2025 08:34
@Monarda Monarda marked this pull request as ready for review October 9, 2025 09:03
@kurup kurup merged commit d43e510 into main Oct 13, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kurup kurup kurup approved these changes

@aqshafei aqshafei Awaiting requested review from aqshafei

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Monarda @kurup