[BE] PR 2/3: Point History Retrieval Logic (#216) by Lucy-SD · Pull Request #1118 · IT-Academy-BCN/ita-challenges-backend

Lucy-SD · 2026-02-24T12:22:47Z

Feature: Implementation of points history and accumulation logic

closes sub-issue: #IT-Academy-BCN/ita-challenges#216

📝 Description

Implementation of the core business logic to retrieve a student's point history. This service processes raw database entries into a structured format suitable for growth charts.

✅ Acceptance Criteria

Logic calculates totalPoints as the sum of all historical entries.
Entries are sorted in decreasing order by date.
Dates are returned in ISO 8601 format.

🔧 Technical Details

DTOs: PointsHistoryResponseDto (contains totalPoints and a list of PointHistoryEntryDto).
Service Logic: UserScoreServiceImp consumes the Flux<UserScoreDocument> from the repository, using collectList() operator to process the data reactively. In a single transformation step, it calculates the arithmetic sum of totalPoints and maps the documents to the PointHistoryEntryDto, returning a Mono<PointsHistoryResponseDto>.
Exceptions: Proper handling of UserNotFound using the common.exception package.

💰 Value Provided

Transforms raw data into "Progress Information," allowing students to visualize their growth over time.

🔓Unlocks

Unblocks the final API Controller: sub-issue #217; and provides the data structure for Frontend graph components.

🔗 Dependencies

Chained to #215 - (PR #1107)
Closes #IT-Academy-BCN/ita-challenges#216

🧪 Test Implementations

Unit Tests: Mocking the Repository to verify the sum calculation and chronological sorting logic in the Service.

🔄 Acceptance Criteria (DoD)

No hardcoded data in the Service.
Code coverage for logic > 80%.
PR description links to the previous shared PR.

👨‍💻 Technical Debts

totalPoints is calculated on-the-fly. For high-volume users, an "Aggregated Totals" table might be needed in the future.
Username Enrichment: Currently, the username is retrieved from the history. If the history is empty, the field returns an empty string. It is recommended to extend IChallengeJwtFacade to extract the username directly from the JWT in future iterations.

Lucy-SD · 2026-02-24T12:24:03Z

IMPORTANT INFO

The original PR was closed by mistake; I've attached the link where you can find the corrections and comments from colleagues.

#1109

All Tests Pass = )

...enge-challenge/src/main/java/com/itachallenge/gamification/service/UserScoreServiceImpl.java

...hallenge-challenge/src/main/java/com/itachallenge/gamification/service/UserScoreService.java

Lucy-SD · 2026-02-24T20:42:36Z

.../src/test/java/com/itachallenge/challenge/dto/gamification/PointsHistoryResponseDtoTest.java

+class PointsHistoryResponseDtoTest {
+
+    @Test
+    void testDtoStructure() {


Issues commented in orginal PR:

#1109 (comment)

[ivilarop]:

This test only checks Lombok-generated builder/getters. It increases coverage but doesn’t protect behavior. If we want to validate the API contract, a Jackson serialization test (e.g., date mapping) would provide real value.

Answer:
[Lucy-SD]:
Done (in separated class).

I understand that testDtoStructure is for coverage/Sonar, but now that we have @JsonTest that validates the actual contract, could we remove this test and the class?

Apparently it could be done, I'll remove it and if for some reason Sonar fails again I'll add it back.

...-challenge/src/test/java/com/itachallenge/gamification/service/UserScoreServiceImplTest.java

Lucy-SD · 2026-02-24T21:44:40Z

Issues addressed in original PR:

#1109 (comment)

[ivilarop]:
I would remove the GamificationMapper for now. The mapping is very simple (2 fields + null handling) and is only used in this service, so the extra class doesn't reduce complexity; it just adds a navigation jump and clutter. Furthermore, the name GamificationMapper is too generic and breaks naming/semantics: it looks like a mapper for the entire module, but in reality, it only maps point history entries (UserScoreDocument -> PointHistoryEntryDto).

Proposal: move the mapping to a private method in PointsServiceImpl (or to the stream itself using a lambda function), and if future reuse or further transformations arise (ISO date format, derived fields, etc.), then extract a PointsHistoryMapper with a specific name.

Answer:
[Lucy-SD]:
The idea behind having a separate mapper was to be able to reuse it for ranking and future implementations. At this stage of development, I understand that it's not necessary. Removed.

Lucy-SD · 2026-02-24T22:21:51Z

All tests still passing after updates = )

carlosPc1987

This aligns well with the persistence layer we have in #1108:
UserScoreDocument with pointsEarned, UserScoreRepository.findByUserIdOrderByCreatedAtDesc,
and the unique index on (user_id, challenge_id).
The removal of distinct() is consistent with that.
When we merge both PRs we’ll have recordPoints (from #1108) and getUserPointsHistory (this PR) under the same UserScoreService naming.
No further comments from my side.
Good job Lucy!

pantalois

Good Lucy! I the work keeps improving!

...hallenge-challenge/src/main/java/com/itachallenge/gamification/service/UserScoreService.java

...enge-challenge/src/main/java/com/itachallenge/gamification/service/UserScoreServiceImpl.java

ivilarop · 2026-02-25T10:42:22Z

.../src/test/java/com/itachallenge/challenge/dto/gamification/PointsHistoryResponseDtoTest.java

+class PointsHistoryResponseDtoTest {
+
+    @Test
+    void testDtoStructure() {


I understand that testDtoStructure is for coverage/Sonar, but now that we have @JsonTest that validates the actual contract, could we remove this test and the class?

.../src/test/java/com/itachallenge/challenge/dto/gamification/PointsHistoryResponseDtoTest.java

...-challenge/src/test/java/com/itachallenge/gamification/service/UserScoreServiceImplTest.java

# Conflicts: # CHANGELOG.md # itachallenge-challenge/src/main/java/com/itachallenge/gamification/document/UserScoreDocument.java # itachallenge-challenge/src/main/java/com/itachallenge/gamification/repository/UserScoreRepository.java # itachallenge-challenge/src/test/java/com/itachallenge/gamification/document/UserScoreDocumentTest.java # itachallenge-challenge/src/test/java/com/itachallenge/gamification/repository/UserScoreRepositoryTest.java

# Conflicts: # CHANGELOG.md

…toTest

…e/dto/gamification/PointsHistoryResponseDtoTest.java

.../src/test/java/com/itachallenge/challenge/dto/gamification/PointsHistoryResponseDtoTest.java

sonarqubecloud · 2026-02-25T12:01:42Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Lucy-SD requested a review from ivilarop February 24, 2026 12:24

Lucy-SD mentioned this pull request Feb 24, 2026

[BE] PR 2/3: Point History Retrieval Logic (#216) #1109

Merged

ivilarop mentioned this pull request Feb 24, 2026

[BE] Gamification: package structure, record score events and unit tests(#228) #1108

Closed

pantalois self-requested a review February 24, 2026 13:44

Lucy-SD commented Feb 24, 2026

View reviewed changes

...enge-challenge/src/main/java/com/itachallenge/gamification/service/UserScoreServiceImpl.java Show resolved Hide resolved

Lucy-SD commented Feb 24, 2026

View reviewed changes

...hallenge-challenge/src/main/java/com/itachallenge/gamification/service/UserScoreService.java Show resolved Hide resolved

Lucy-SD commented Feb 24, 2026

View reviewed changes

...-challenge/src/test/java/com/itachallenge/gamification/service/UserScoreServiceImplTest.java Show resolved Hide resolved

Lucy-SD requested review from Apani13, carlosPc1987 and polserrano8 February 24, 2026 21:46

carlosPc1987 approved these changes Feb 25, 2026

View reviewed changes

pantalois approved these changes Feb 25, 2026

View reviewed changes

carlosPc1987 mentioned this pull request Feb 25, 2026

[BE] PR 3/3: GET Endpoint for User Points History (#217) #1116

Merged

Lucy-SD removed request for Apani13 and polserrano8 February 25, 2026 09:23

ivilarop requested changes Feb 25, 2026

View reviewed changes

Lucy-SD added 10 commits February 25, 2026 12:49

add PointEntry & PointHistory Dtos and PointService

20883dd

add service, servImpl, dto & mapper for gamification

6b8fa85

add PointsServiceImplTests

bde748a

format edit

202632e

updated changelog 2/3

506e42e

# Conflicts: # CHANGELOG.md

updated PointsServImp and Test to use username

efd454d

returned methods to consume userId

7bc166f

add uysername to dto & dto builder

6d72ef5

renamed dto's to be cohesive

a23f356

Lucy-SD and others added 15 commits February 25, 2026 12:51

added mapper & dto testing

7f57fa5

add distinct filter for challengeId, updated & added specific test

993adb5

updated changelog

6b64882

force GH to detect files

dabf514

updated points to pointsEarned

4aa59ae

updated PointsService-Impl-Test to UserScoreService

ab00409

deleted mapper and it's uses

2e994a0

updated UserScoreServImp & UserScoreServImpTest

74b3e33

add UserScoreDtoJsonTest & updated UserScoreServImpTest

228fa1c

updated serviceTests

b39c493

updated changelog to delete mapper impl

afba98e

updated collectors toList

c603c68

fix: update naming of UserScoreDtoJasonTest to PointsHistoryResponseD…

cd80468

…toTest

Delete itachallenge-challenge/src/test/java/com/itachallenge/challeng…

c4b8282

…e/dto/gamification/PointsHistoryResponseDtoTest.java

chore:modified PointsHistoryResponseDtoTest file name

ced6d51

pantalois force-pushed the feature/190-2/point-history-retrival-logic branch from fce0295 to ced6d51 Compare February 25, 2026 11:53

ivilarop approved these changes Feb 25, 2026

View reviewed changes

.../src/test/java/com/itachallenge/challenge/dto/gamification/PointsHistoryResponseDtoTest.java Show resolved Hide resolved

ivilarop merged commit 5ebec52 into develop Feb 25, 2026
3 checks passed

Conversation

Lucy-SD commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Feature: Implementation of points history and accumulation logic

📝 Description

✅ Acceptance Criteria

🔧 Technical Details

💰 Value Provided

🔓Unlocks

🔗 Dependencies

🧪 Test Implementations

🔄 Acceptance Criteria (DoD)

👨‍💻 Technical Debts

Uh oh!

Lucy-SD commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

IMPORTANT INFO

All Tests Pass = )

Uh oh!

Uh oh!

Uh oh!

Lucy-SD Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

ivilarop Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

pantalois Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Lucy-SD commented Feb 24, 2026

Uh oh!

Lucy-SD commented Feb 24, 2026

All tests still passing after updates = )

Uh oh!

carlosPc1987 left a comment

Choose a reason for hiding this comment

Uh oh!

pantalois left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ivilarop Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Feb 25, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Lucy-SD commented Feb 24, 2026 •

edited

Loading

Lucy-SD commented Feb 24, 2026 •

edited

Loading