PR4/4 Eliminate all deprecated endpoints to only maintain the new endpoints in favorite controller package and the test related to it in the user microservice (#1115)#1119
Open
polserrano8 wants to merge 5 commits into#201-Update-the-challenge-micro-in-file-FavoriteController-to-call-new-User-Favorites-endpoints-reliablyfrom
Open
PR4/4 Eliminate all deprecated endpoints to only maintain the new endpoints in favorite controller package and the test related to it in the user microservice (#1115)#1119polserrano8 wants to merge 5 commits into#201-Update-the-challenge-micro-in-file-FavoriteController-to-call-new-User-Favorites-endpoints-reliablyfrom
polserrano8 wants to merge 5 commits into#201-Update-the-challenge-micro-in-file-FavoriteController-to-call-new-User-Favorites-endpoints-reliablyfrom
Conversation
|
polserrano8
changed the base branch from
develop
to
#201-Update-the-challenge-micro-in-file-FavoriteController-to-call-new-User-Favorites-endpoints-reliably
polserrano8
force-pushed
the
#201-Update-the-challenge-micro-in-file-FavoriteController-to-call-new-User-Favorites-endpoints-reliably
branch
from
6b9f02f to
de4dcf7
Compare
polserrano8
force-pushed
the
#1115-Eliminate-all-deprecated-endpoints-to-only-maintain-the-new-endpoints-in-favorite-controller-package-and-the-test-related-to-it-in-the-user-microservice-new
branch
from
818968b to
a6758fd
Compare
Update the Challenge -> User favorites route configuration to use the new User Favorites contract while keeping Challenge public favorites endpoints unchanged. Changes: - update `user.endpoints.favorites` in challenge main config - update `user.endpoints.favorites` in challenge test config - update `UserServiceImplTest` favorites URL/template expectations - update APISIX dev/pro routes to allow the new favorites path (`GET, POST, DELETE`) - keep legacy route available during staged migration (if still needed) This aligns the challenge microservice with the User favorites endpoint refactor and prevents route mismatches in runtime/tests. Updated the changelog
Deletes `FavoriteLegacyController` and its legacy unit/integration tests for the deprecated `/userinteraction/favorites` contract, and removes the legacy favorites successor-path configuration from `application.yml`. Also the CHANGELOG.md has been removed accordingly.
polserrano8
force-pushed
the
#1115-Eliminate-all-deprecated-endpoints-to-only-maintain-the-new-endpoints-in-favorite-controller-package-and-the-test-related-to-it-in-the-user-microservice-new
branch
from
a6758fd to
cbd40a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated Favorites legacy API from the User microservice and cleans up the related legacy-only configuration and tests.
In Scope
Remove FavoriteLegacyController (/itachallenge/api/v1/userinteraction/favorites/...) from itachallenge-user.
Remove legacy controller tests:
FavoriteControllerLegacyTest
FavoriteControllerIntegrationLegacyTest
Remove legacy deprecation/successor-path config from application.yml (app.api.favorites.successor-version.*), which was only used by the legacy controller.
Out of Scope
No changes to Favorites business logic/service behavior.
No database changes.
No changes to the new/restful favorites endpoints contract.
No changes to Challenge microservice public APIs or frontend APIs in this PR.
Be careful this PR only can be merged when the others three PRs previosuly done have been merged. (#199,#201,#202), if front-end or backend are not correctly updated this PR could break the connection front with the back in terms of favourites.
All test have been passed after the clean up of the deprecated endpoints.