Conversation
…ilters modal (pending to delete the mock of the languages for testing purposes)
…nge list filters component
…HEMA to filter component tests
…filter components
…g filtering feature
There was a problem hiding this comment.
Nice implementation. I was confused at first since I expected to see the tags appear as I selected languages (I think the modifications to the challenge-filters-trigger template threw me off), but I understand that my PR and yours are strictly related, as you need my implementation to make yours work. Maybe change some details in the PR explanation can help everybody understand this better
Hopefully we won’t encounter too many conflicts during the merging process. I saw that you anticipated this with a parallel event, so it shouldn’t create any major issues. Maybe we can open a future PR to integrate our changes even better.
All tests pass! Approved!
vaniaferreresteban
left a comment
There was a problem hiding this comment.
I think the logic of the tagItems should be out of the filter logic, but it's also truth that the filter is who decides what will be challanges... the other components must use this source to manage a single truth, let's discuss tomorrow.
.../modules/starter/components/challenge-filters-trigger/challenge-filters-trigger.component.ts
Outdated
Show resolved
Hide resolved
…allenge card component.
…e format and use the new service
…lenge-filters-trigger component
…ags-slected-filters
…rom challenge-filters-trigger component
…ags-slected-filters
vaniaferreresteban
left a comment
There was a problem hiding this comment.
It's true that you need adittional filtering of the tags to display on your branch, the overlap query is needed for now, let's create a tech debt and link that to this pr
…ags-slected-filters
…ge-filters-trigger component to have less repeated lines
|



Description of the task
As part of the new filtering system refactor, the challenge filters modal needs support for tag-based filtering. Currently, the challenge-filters-trigger component does not manage tags dynamically and lacks the logic required to retrieve and display them depending on the selected languages.
Important
This task introduces the data flow and logic necessary to enable tag filtering. It prepares the filter system for the next UI-focused step of the parent task #230. This PR focuses on functionality and data handling. Styling improvements will be handled in #231
What does this task aim to accomplish?
The goal is to dynamically retrieve tags based on the languages selected by the user and allow them to be selected as part of the filtering criteria.
To achieve this:
📁 Files changed or created
Changes:
language-filter.component.tschallenge-list-filters.component.tschallenge-filters-trigger.component.tsDefinition of done
Out of scope in this task
Tests / Verification
Manual verification:
• Selecting languages updates available tags
• Tags appear grouped by language
• Applying filters emits correct tag IDs
• Reopening modal restores selected tags