Skip to content

feature (shared) Created loading state enum#782

Open
JungleGiu wants to merge 4 commits intodevelopfrom
feature/255-loading-state-enum
Open

feature (shared) Created loading state enum#782
JungleGiu wants to merge 4 commits intodevelopfrom
feature/255-loading-state-enum

Conversation

@JungleGiu
Copy link
Collaborator

📍 Context

Related subissue

Since we are planning to implement a loading state in the landing page (Parent Issue) a unique standard for handling loading state is needed across the whole app. An enum seemed the way to avoid any inconsistencies in the future development of the app.

✅ What's been done

  • Created a LoadingStatus enum under src/app/shared/enums/loading-status.enum.ts with three values: LOADING, SUCCESS, and ERROR
  • Exported the enum so it can be imported cleanly by any component or service
  • Added a spec file (loading-status.enum.spec.ts) to verify the enum values and ensure no unintended changes are introduced in the future

🔍 Proof

Screenshot 2026-03-11 alle 17 22 02

🚩Notes

  • The enum uses string values (e.g. LOADING = 'LOADING') instead of numeric ones for better readability when debugging or logging
  • This PR does not introduce any usage of the enum yet — adoption will happen incrementally in follow-up PRs as components and services are refactored
  • No breaking changes

Copy link
Collaborator

@otrocadev otrocadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very simple and focused. Perfect. Let's keep going! 💪🏼

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants