Skip to content

Fix PCES overflowing VRTime internal tick counter when run without a termination argument #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huskabyte wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix PCES overflowing VRTime internal tick counter when run without a termination argument #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sim.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"fmt"
"github.com/iti/cmdline"
"github.com/iti/evt/evtm"
"github.com/iti/evt/vrtime"
"github.com/iti/mrnes"
"github.com/iti/rngstream"
"golang.org/x/exp/slices"
Expand Down Expand Up @@ -103,7 +104,9 @@ func ReadSimArgs() (*cmdline.CmdParser, *evtm.EventManager) {
}

// if there is no stop argument, termination is made very large
termination = math.MaxFloat64/10.0
// termination CANNOT be the max float value because it will overflow vrtime's internal
// (int64) tick counter and become VERY negative.
termination = vrtime.TicksToSeconds(math.MaxInt64 / 2)
if cp.IsLoaded("stop") {
termination = cp.GetVar("stop").(float64)
}
Expand Down