Skip to content

Conversation

@YuryHrytsuk
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk commented Apr 4, 2025

Bonus:

  • Surround traefik rules in '' to avoid bash execution `...`
  • Set conservative and slow update_config to make sure only 1 containers at a time is updated (with a noticeable delay in between)

What do these changes do?

Related issue/s

Related PR/s

Checklist

  • I tested and it works

Related issue: ITISFoundation#984

Bonus:
* Surround traefik rules in '' to avoid bash execution `...`
* Set conservative and slow update_config to make sure only 1 containers
  at a time is updated (with a noticeable delay in between)
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice thx

@YuryHrytsuk YuryHrytsuk merged commit 7828cf8 into ITISFoundation:main Apr 14, 2025
3 checks passed
@YuryHrytsuk YuryHrytsuk deleted the traefik-rolling-config-updates branch April 14, 2025 11:17
YuryHrytsuk added a commit to YuryHrytsuk/osparc-ops-environments that referenced this pull request Apr 22, 2025
j2cli that we use preserves quotes around variable value being
substituted kolypto/j2cli#77. This leads to a
wrong label syntax (e.g. label="asda" instead of label=asda)

Related PR(s):
* ITISFoundation#1013

Related Issue(s):
* closes ITISFoundation#1028
@YuryHrytsuk YuryHrytsuk mentioned this pull request Apr 22, 2025
1 task
YuryHrytsuk added a commit that referenced this pull request Apr 22, 2025
j2cli that we use preserves quotes around variable value being
substituted kolypto/j2cli#77. This leads to a
wrong label syntax (e.g. label="asda" instead of label=asda)

Related PR(s):
* #1013

Related Issue(s):
* closes #1028
YuryHrytsuk added a commit that referenced this pull request Apr 22, 2025
j2cli that we use preserves quotes around variable value being
substituted kolypto/j2cli#77. This leads to a
wrong label syntax (e.g. label="asda" instead of label=asda)

Related PR(s):
* #1013

Related Issue(s):
* closes #1028
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants