Skip to content

Rolling deploy simcore (secrets) + Makefile targets #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 15, 2025
Merged

Rolling deploy simcore (secrets) + Makefile targets #1015

merged 4 commits into from
Apr 15, 2025

Conversation

@YuryHrytsuk
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk commented Apr 14, 2025 •
edited
Loading

What do these changes do?

  1. Automatically copy assets (dask certs)
  2. Deploy simcore can now be easily reproduced manually
  3. Implement Rolling dask cert update

FYI: @matusdrobuliak66

Related issue/s

Related PR/s

Checklist

  • I tested and it works

@YuryHrytsuk
Add rolling deploy simcore makefile targets
555bd7d 
1. Automatically copy assets (dask certs)
2. Deploy simcore can now be easily reproduced manually
3. Implement Rolling dask cert update

Related issues:
* ITISFoundation#984
* ITISFoundation#934
@YuryHrytsuk
Merge remote-tracking branch 'upstream/main' into dask-certificates-r…
9b37822 
…olling-config-updates
@YuryHrytsuk YuryHrytsuk added this to the Pauwel Kwak milestone Apr 14, 2025
@YuryHrytsuk YuryHrytsuk requested a review from sanderegg April 14, 2025 13:54
@YuryHrytsuk YuryHrytsuk self-assigned this Apr 14, 2025
@YuryHrytsuk
stack_with_prefix.yml: remove unused docker image tag
0b1a761 
This variable is not used. Instead script is sourcing repo config that
defines (overrides) docker image tag
@YuryHrytsuk
Update target doc: remove docker image tag
687f7ce
mrnicegyu11
mrnicegyu11 approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very very nice, thanks!

@YuryHrytsuk YuryHrytsuk merged commit 0e09f11 into ITISFoundation:main Apr 15, 2025
3 checks passed
YuryHrytsuk added a commit to YuryHrytsuk/osparc-ops-environments that referenced this pull request Apr 15, 2025
@YuryHrytsuk
prepare simcore stack: secret path processing
9d15918 
In ITISFoundation#1015 secret path processing was removed what led to a bug
(stack.yml file contains absolute paths to secrets which do not exist in
deploy_simcore stage)

Related PRs:
* ITISFoundation#1015
This was referenced Apr 15, 2025
Merged
Open
Closed
YuryHrytsuk added a commit that referenced this pull request Apr 15, 2025
@YuryHrytsuk
prepare simcore stack: secret path processing (#1017)
ef31aed 
In #1015 secret path processing was removed what led to a bug
(stack.yml file contains absolute paths to secrets which do not exist in
deploy_simcore stage)

Related PRs:
* #1015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@YuryHrytsuk YuryHrytsuk

Labels

None yet

Projects

None yet

Milestone

Pauwel Kwak

Development

Successfully merging this pull request may close these issues.

2 participants

@YuryHrytsuk @mrnicegyu11