Skip to content

Add sto-worker-cpu-bound service #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

Add sto-worker-cpu-bound service #1023

merged 2 commits into from
Apr 15, 2025

Conversation

@YuryHrytsuk
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk commented Apr 15, 2025 •
edited by giancarloromeo
Loading

What do these changes do?

Load while downloading 2 files (of 500 MB)
image

Related issue/s

Related PR/s

Checklist

  • I tested and it works
  • Service has resource limits and reservations
  • Service has placement constraints or is global
  • Service is restartable
  • Service restart is zero-downtime
  • Service is monitored (via prometheus and grafana)
  • Service is not bound to one specific node (e.g. via files or volumes)
  • Relevant OPS E2E Test are added
  • Service's Public URL is included in maintenance mode
  • Service's Public URL is included in testing mode

@YuryHrytsuk YuryHrytsuk added this to the Pauwel Kwak milestone Apr 15, 2025
@YuryHrytsuk YuryHrytsuk self-assigned this Apr 15, 2025
giancarloromeo
giancarloromeo approved these changes Apr 15, 2025
View reviewed changes
Copy link

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👌

@YuryHrytsuk
Bump memory limit
858cbef 
Based on experiment data (we saw 600MB memory usage uploading 2 files)
@YuryHrytsuk YuryHrytsuk requested a review from GitHK April 15, 2025 12:43
@YuryHrytsuk YuryHrytsuk merged commit bd88ad4 into ITISFoundation:main Apr 15, 2025
3 checks passed
@YuryHrytsuk YuryHrytsuk deleted the add-sto-worker-cpu-bound-service branch April 15, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11 mrnicegyu11 is a code owner

@GitHK GitHK Awaiting requested review from GitHK

Assignees

@YuryHrytsuk YuryHrytsuk

Labels

FAST

Projects

None yet

Milestone

Pauwel Kwak

Development

Successfully merging this pull request may close these issues.

2 participants

@YuryHrytsuk @giancarloromeo