-
Notifications
You must be signed in to change notification settings - Fork 6
Fix uid for tempo datasource #1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
YuryHrytsuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me test it on AWS Master before merging.
That would be great! Thanks a lot. Let me know when you have given it a try |
@bisgaard-itis you can check it on your own on aws master (you change is deployed there manually) |
|
This might be related to the fact that on aws master we use aws rabbit (not self-hosted)? |
@YuryHrytsuk this is just because there is no data. Maybe noone was hitting these endpoints within the given time frame. I just checked again on aws master and it looks fine to me when I look at the catalog for the last 3 hours:
|
YuryHrytsuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Thanks 🙏



What do these changes do?
Hardcode the uid of the Tempo datasource. This seems to be the issue in #1156. I can see that other datasources which are referenced in dashboards have hardcoded uids. Once this is merged I will have to check that the rpc sections of the simcore service dashboards all work as expected.
Related issue/s
Related PR/s
Checklist