CPU Limit Adjustments #1181
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -115,11 +115,12 @@ services: | |
| parallelism: 1 | ||
| placement: | ||
| constraints: | ||
| - node.labels.gpu!=true | ||
| - node.labels.dynamicsidecar!=true | ||
|
||
| resources: | ||
| limits: | ||
| memory: 1G | ||
| cpus: '6' | ||
|
There was a problem hiding this comment. Why this number? What is the reasoning behind? There was a problem hiding this comment. the number of available CPUs are not taken into account, and afaik this is correct, they do not matter (as much). [talk to me for clarification ;)] The number is a guess based on prometheus observation on osparc-master (e.g. PromQL There was a problem hiding this comment. nevertheless @mrnicegyu11 if you set a limit above what is available in reality, the container never starts. There was a problem hiding this comment. OK then I vote for removing the limit alltogether. I can see that it was throttled >7 (additional) CPUs at a time on master, so 8 CPUs would be the right number. But this is too high to put into the section if what @sanderegg says is correct. @YuryHrytsuk @sanderegg There was a problem hiding this comment. Optional: Test CPU Limit |
||
| reservations: | ||
| memory: 128M | ||
| cpus: '0.1' | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -481,7 +481,7 @@ services: | |
| cpus: "0.1" | ||
| memory: "256M" | ||
| limits: | ||
| cpus: "1.0" | ||
| memory: "1G" | ||
|
|
||
| director-v2: | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chore:
.master.docker compose file or j2 instead of negative labelson all deployment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional: test / precommit (minor)