Skip to content

Extend common makefile #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

Extend common makefile #1196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions scripts/common.Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,12 @@ guard-%:
guard-optional-%:
@:

guard-optional-bool-%:
@if [ "${${*}}" != "true" ] && [ "${${*}}" != "false" ] && [ "${${*}}" != "" ]; then \
echo "Argument '${*}' must be 'true', 'false', or empty"; \
exit 1; \
fi;

# Gracefully use defaults and potentially overwrite them, via https://stackoverflow.com/a/49804748
%: %-default
@ true
Expand Down Expand Up @@ -385,3 +391,27 @@ $(WAIT_FOR_IT): ## installs wait4x utility for WAIT_FOR_IT functionality
@mv /tmp/wait4x/wait4x $@
@rm -rf /tmp/wait4x
@$@ version

# Arguments
# 1 - message to show (e.g. Are you sure?)
# 2 - input to confirm action (e.g. yes)
# 3 - force confirm (e.g. true)
#
# Examples
# $(call confirm_action) -- use with default messages
# $(call confirm_action,Do you want to delete all files?) -- overwrite confirm message
# $(call confirm_action,,,$(CI)) -- ignore in CI (CI := true)
# echo before; $(call confirm_action); echo after -- chain in bash
define confirm_action
CONFIRM_MSG="$(if $(1),$(1),Are you sure?)"; \
CONFIRM_KEY="$(if $(2),$(2),yes)"; \
SKIP_CHECK="$(if $(3),$(3),false)"; \
if [ "$$SKIP_CHECK" != true ]; then \
echo "$$CONFIRM_MSG"; \
read -p "Type '$$CONFIRM_KEY' to confirm: " USER_INPUT; \
if [ "$$USER_INPUT" != "$$CONFIRM_KEY" ]; then \
echo "CONFIRM_KEY does not match. Aborted."; \
exit 1; \
fi; \
fi
endef
Loading