Skip to content

Add tracing sampling percentage #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 9, 2025
Merged

Add tracing sampling percentage #1230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ddf6fbf
move services around (cleanup)
bisgaard-itis Jan 11, 2024
40da8ce
add first services
bisgaard-itis Jan 11, 2024
381aad4
add more prometheus configs
bisgaard-itis Jan 12, 2024
0066ab5
add all instrumented simcore services to grafana dashboard
bisgaard-itis Jan 12, 2024
895d2d9
add newline in grafana dashboard json
bisgaard-itis Jan 12, 2024
80ae5f2
minor improvement to simcore service grafana dashboard
bisgaard-itis Jan 12, 2024
9fbd977
end with empty lineto please gh
bisgaard-itis Jan 12, 2024
ea19265
several other minor changes
bisgaard-itis Jan 15, 2024
48a9ec4
another minor fix
bisgaard-itis Jan 15, 2024
b849a6b
ensure newline
bisgaard-itis Jan 15, 2024
4e52efb
remove TRACING_OPENTELEMETRY_COLLECTOR_SAMPLING_PERCENTAGE and add TR…
bisgaard-itis Oct 8, 2025
1c9774b
fix files which don't match itis/main
bisgaard-itis Oct 8, 2025
0e9a1e6
Merge branch 'main' into 1090-implement-tracing-sampling-strategy
bisgaard-itis Oct 8, 2025
64fd9c1
TRACING_SAMPLING_PROBABILITY -> TRACING_OPENTELEMETRY_SAMPLING_PROBAB…
bisgaard-itis Oct 9, 2025
2a8a755
Merge branch 'main' into 1090-implement-tracing-sampling-strategy
mrnicegyu11 Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion services/jaeger/docker-compose.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ services:
- interactive_services_subnet
environment:
TRACING_OPENTELEMETRY_COLLECTOR_BATCH_SIZE: ${TRACING_OPENTELEMETRY_COLLECTOR_BATCH_SIZE}
TRACING_OPENTELEMETRY_COLLECTOR_SAMPLING_PERCENTAGE: ${TRACING_OPENTELEMETRY_COLLECTOR_SAMPLING_PERCENTAGE}
TRACING_OPENTELEMETRY_COLLECTOR_EXPORTER_ENDPOINT: ${TRACING_OPENTELEMETRY_COLLECTOR_EXPORTER_ENDPOINT}
TRACING_OPENTELEMETRY_COLLECTOR_SERVICE_TELEMETRY_LOG_LEVEL: ${TRACING_OPENTELEMETRY_COLLECTOR_SERVICE_TELEMETRY_LOG_LEVEL}

Expand Down
2 changes: 0 additions & 2 deletions services/jaeger/opentelemetry-collector-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ processors:
batch:
timeout: 5s
send_batch_size: ${TRACING_OPENTELEMETRY_COLLECTOR_BATCH_SIZE}
probabilistic_sampler:
sampling_percentage: ${TRACING_OPENTELEMETRY_COLLECTOR_SAMPLING_PERCENTAGE}
filter/drop_healthcheck:
error_mode: ignore
traces:
Expand Down
1 change: 0 additions & 1 deletion services/jaeger/template.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ MONITORING_DOMAIN=${MONITORING_DOMAIN}
PUBLIC_NETWORK=${PUBLIC_NETWORK}
MONITORED_NETWORK=${MONITORED_NETWORK}
TRACING_OPENTELEMETRY_COLLECTOR_BATCH_SIZE=${TRACING_OPENTELEMETRY_COLLECTOR_BATCH_SIZE}
TRACING_OPENTELEMETRY_COLLECTOR_SAMPLING_PERCENTAGE=${TRACING_OPENTELEMETRY_COLLECTOR_SAMPLING_PERCENTAGE}
TRACING_OPENTELEMETRY_COLLECTOR_EXPORTER_ENDPOINT=${TRACING_OPENTELEMETRY_COLLECTOR_EXPORTER_ENDPOINT}
TRACING_OPENTELEMETRY_COLLECTOR_SERVICE_TELEMETRY_LOG_LEVEL=${TRACING_OPENTELEMETRY_COLLECTOR_SERVICE_TELEMETRY_LOG_LEVEL}
SWARM_STACK_NAME=${SWARM_STACK_NAME}
1 change: 1 addition & 0 deletions services/simcore/docker-compose.deploy.aws.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ services:
- "--tracing.serviceName=simcore-traefik"
- "--tracing.otlp.http.endpoint=http://otel-collector:4318/v1/traces"
- "--tracing.addinternals=false"
- "--tracing.sampleRate=${TRACING_OPENTELEMETRY_SAMPLING_PROBABILITY}"
deploy:
resources:
limits:
Expand Down
1 change: 1 addition & 0 deletions services/simcore/docker-compose.deploy.dalco.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ services:
- "--tracing.serviceName=simcore-traefik"
- "--tracing.otlp.http.endpoint=http://otel-collector:4318/v1/traces"
- "--tracing.addinternals=false"
- "--tracing.sampleRate=${TRACING_OPENTELEMETRY_SAMPLING_PROBABILITY}"
deploy:
resources:
limits:
Expand Down
2 changes: 2 additions & 0 deletions services/simcore/docker-compose.deploy.local.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ services:
- "--tracing.serviceName=simcore-traefik"
- "--tracing.otlp.http.endpoint=http://otel-collector:4318/v1/traces"
- "--tracing.addinternals=false"
- "--tracing.sampleRate=${TRACING_OPENTELEMETRY_SAMPLING_PROBABILITY}"

deploy:
labels:
# oSparc postgres
Expand Down
1 change: 1 addition & 0 deletions services/simcore/docker-compose.deploy.master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ services:
- "--tracing.serviceName=simcore-traefik"
- "--tracing.otlp.http.endpoint=http://otel-collector:4318/v1/traces"
- "--tracing.addinternals=false"
- "--tracing.sampleRate=${TRACING_OPENTELEMETRY_SAMPLING_PROBABILITY}"
deploy:
resources:
limits:
Expand Down
2 changes: 2 additions & 0 deletions services/simcore/docker-compose.deploy.public.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ services:
- "--tracing.serviceName=simcore-traefik"
- "--tracing.otlp.http.endpoint=http://otel-collector:4318/v1/traces"
- "--tracing.addinternals=false"
- "--tracing.sampleRate=${TRACING_OPENTELEMETRY_SAMPLING_PROBABILITY}"

deploy:
labels:
- prometheus-job=traefik_simcore_production
Expand Down
1 change: 1 addition & 0 deletions services/traefik/template.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,4 +103,5 @@ TRAEFIK_PROVIDERS_FILE_WATCH=true
# Tracing
TRAEFIK_TRACING_ADDINTERNALS=false
TRAEFIK_TRACING_OTLP_HTTP_ENDPOINT=${TRACING_OPENTELEMETRY_COLLECTOR_ENDPOINT}:${TRACING_OPENTELEMETRY_COLLECTOR_PORT}
TRAEFIK_TRACING_SAMPLERATE=${TRACING_OPENTELEMETRY_SAMPLING_PROBABILITY}
TRAEFIK_TRACING_SERVICENAME=ops-traefik
Loading