Process logs before sending them to loki #1243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move services around (cleanup) * add first services * add more prometheus configs * add all instrumented simcore services to grafana dashboard * add newline in grafana dashboard json * minor improvement to simcore service grafana dashboard * end with empty lineto please gh * several other minor changes * another minor fix * ensure newline * remove TRACING_OPENTELEMETRY_COLLECTOR_SAMPLING_PERCENTAGE and add TRACING_SAMPLING_PROBABILITY * fix files which don't match itis/main * TRACING_SAMPLING_PROBABILITY -> TRACING_OPENTELEMETRY_SAMPLING_PROBABILITY --------- Co-authored-by: Dustin Kaiser <[email protected]>
bisgaard-itis
requested review from
YuryHrytsuk and
mrnicegyu11
as code owners
YuryHrytsuk
approved these changes
Oct 27, 2025
| .log_level = parsed_fields.log_level | ||
| .log_timestamp = parsed_fields.log_timestamp | ||
| .log_source = parsed_fields.log_source | ||
| .log_uid = parsed_fields.log_uid |
There was a problem hiding this comment.
Does this becomes a label in Loki?
There was a problem hiding this comment.
They are not labels, because labels should have low cardinality (https://grafana.com/docs/loki/latest/get-started/labels/bp-labels/). Instead this adds them as keys in the log json. Then there is a json parser directly in loki and after applying that one can filter on these fields.
| if exists(.message) { | ||
| parsed_fields, err = parse_regex(.message, r'log_level=(?P<log_level>[^|]*) \| log_timestamp=(?P<log_timestamp>[^|]*) \| log_source=(?P<log_source>[^|]*) \| log_uid=(?P<log_uid>[^|]*) \| log_oec=(?P<log_oec>[^|]*) \| log_trace_id=(?P<log_trace_id>[^|]*) \| log_span_id=(?P<log_span_id>[^|]*) \| log_msg=(?P<log_msg>.*)$') | ||
| if err == null { | ||
| .log_level = parsed_fields.log_level |
There was a problem hiding this comment.
Probably this won't parse traefik logs.
We did fix this in Graylog #293
Might be interesting if you want to include traefik log level
mrnicegyu11
reviewed
Oct 27, 2025
There was a problem hiding this comment.
@bisgaard-itis please consider YH's comments, or at least the traefik one. Thanks a lot, merge at your own discretion please
mrnicegyu11
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue/s
Related PR/s
Checklist