🔨: Add hardcoded node label addition on local-k8s/kind #841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yury Hrytsuk <[email protected]>
mrnicegyu11
added
t:enhancement
|
We can use the nativa Kind configuration for this. I propose to go this way. I can take it over, if you want https://kind.sigs.k8s.io/docs/user/configuration/#extra-labels |
|
Yes very good, I will close this MR |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Make sure that adminer starts on osparc.local, for now by manually adding a label-add step.
Very hardcoded, this is a true FIXME. I will open an issue in osparc-ops-environments. I dont know how to do this more automatic in a smart way for now. Do we have a list of valid node labels somewhere that we could iterate and always add to the single-node local-k8s kind cluster? 🤔
Related issue/s
Related PR/s
Checklist