Skip to content

Fix: Varia, Cleanup #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jan 3, 2025
Merged

Fix: Varia, Cleanup #911

merged 20 commits into from
Jan 3, 2025

Conversation

@mrnicegyu11
Copy link
Member

@mrnicegyu11 mrnicegyu11 commented Dec 13, 2024 •
edited
Loading

What do these changes do?

  • Refactor jinja2cli calling convention: Always pass .env file path explictly (necessary preparation for grafana-terraform)
  • Remove unused grafana-image-renderer files
  • enhance scripts/Makefiles for osparc.local

Related issue/s

Related PR/s

Checklist

  • I tested and it works

mrnicegyu11 and others added 17 commits October 15, 2024 16:18
@mrnicegyu11
wip
f0d8cf0
@mrnicegyu11
Merge remote-tracking branch 'upstream/main' into main
e906b41
@mrnicegyu11
Merge remote-tracking branch 'upstream/main' into main
14c751d
@mrnicegyu11
Add csi-s3 and have portainer use it
293f63c
@mrnicegyu11
Change request @Hrytsuk 1GB max portainer volume size
f7f72ec
@mrnicegyu11
t push
94cfb76 
Merge remote-tracking branch 'upstream/main'
@mrnicegyu11
Merge remote-tracking branch 'upstream/main'
509c717
@mrnicegyu11
Merge remote-tracking branch 'upstream/main'
1a65ecf
@mrnicegyu11
Merge remote-tracking branch 'upstream/main'
77ee45e
@mrnicegyu11
Arch Linux Certificates Customization
c9c70d6
@mrnicegyu11
Merge remote-tracking branch 'upstream/main'
7b8be53
@mrnicegyu11
Merge remote-tracking branch 'upstream/main'
bcd61cd
@mrnicegyu11
Merge remote-tracking branch 'upstream/main'
58e1030
@mrnicegyu11
Add up-local makefile target for simcore stack
bc45907
@mrnicegyu11
Remove unused docker config file in monitoring stack
0a809cb
@mrnicegyu11
Remove unused env-var - grafana
9149de6
@mrnicegyu11
Use up-local makefile target for local simcore in deploy_everything_l…
e8e370c 
…ocally.sh
@mrnicegyu11 mrnicegyu11 self-assigned this Dec 13, 2024
@mrnicegyu11 mrnicegyu11 added t:enhancement New feature or request FAST labels Dec 18, 2024
@mrnicegyu11 mrnicegyu11 added this to the Event Horizon milestone Dec 18, 2024
@mrnicegyu11 mrnicegyu11 marked this pull request as ready for review December 18, 2024 08:39
@mrnicegyu11 mrnicegyu11 mentioned this pull request Dec 23, 2024
Merged
1 task
YuryHrytsuk
YuryHrytsuk approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not update jinja definition in this PR

$(REPO_BASE_DIR)/.venv/bin/j2 --format=env $(1) $(2) -o $(3)

Otherwise, fine with me. Thanks 🙏

@mrnicegyu11 mrnicegyu11 merged commit 8c0bae8 into ITISFoundation:main Jan 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuryHrytsuk YuryHrytsuk YuryHrytsuk approved these changes

Assignees

@mrnicegyu11 mrnicegyu11

Labels

FAST t:enhancement New feature or request

Projects

None yet

Milestone

Event Horizon

Development

Successfully merging this pull request may close these issues.

2 participants

@mrnicegyu11 @YuryHrytsuk