Seperate dalco-staging: disable redis special handling #976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrnicegyu11
changed the title
mrnicegyu11
added
t:enhancement
YuryHrytsuk
reviewed
Mar 3, 2025
Collaborator
YuryHrytsuk
left a comment
YuryHrytsuk
left a comment
There was a problem hiding this comment.
I think there is special handling in monitoring stack which relies on MONITORED_STACK_NAMES (e.g. pgsql_quiry_exporter_config.yaml.j2)
Comment on lines
-9
to
-14
| REDIS_STAGING_PASSWORD=${REDIS_STAGING_PASSWORD} | ||
| REDIS_STAGING_DATABASES=${REDIS_STAGING_DATABASES} | ||
| REDIS_STAGING_HOST=${REDIS_STAGING_HOST} | ||
| REDIS_STAGING_PORT=${REDIS_STAGING_PORT} | ||
| REDIS_STAGING_USER=${REDIS_STAGING_USER} | ||
| REDIS_STAGING_SECURE=${REDIS_STAGING_SECURE} |
Collaborator
There was a problem hiding this comment.
Is there a respective PR removing this ENV?
Member
Author
There was a problem hiding this comment.
Yes there was, it is already merged they have been removed in all repo.config.template files already
Member
Author
Good find, I have adresses this now 🤩 |
mrnicegyu11
added a commit
to mrnicegyu11/osparc-ops-environments
that referenced
this pull request
Mar 5, 2025
…n#976) * wip * Add csi-s3 and have portainer use it * Change request @Hrytsuk 1GB max portainer volume size * Arch Linux Certificates Customization * Remove dalco special staging handling * remove accidental commit * remove accidental commit * Remove dalco staging special handling --------- Co-authored-by: Dustin Kaiser <[email protected]>
mrnicegyu11
added a commit
that referenced
this pull request
Mar 13, 2025
* wip * Add csi-s3 and have portainer use it * Change request @Hrytsuk 1GB max portainer volume size * Arch Linux Certificates Customization * Add grafana terrform tooling * Make osparc-config dotenv-precommit pass: Use all caps env-vars * Refactoring: jinja2 takes .env file path as explicit argument (like in osparc-config) * Make CI_ENV_FILE vailable in makefile * Refactor makefile targets * Add grafana terraform gitignore * Rename envvar: TF_STATE_S3_GRAFANAKEY * Remove old scripts, makefile targets * Remove unused files * undue arch style commit * Remove references to Tempo * CHange request YH: Stop trying tor ecah grafana eventually * Change request YH: Move tf scripts to terraform folder * Change request YH: stricter check * Add files remove typo * Add terraform fmt pre-commit hook * Use ansible.env file in lieu of ci.env if available * Rename and refactor * wip * wip * remove line * Makefile repo base dir without git * Grafana terraform ceph fixes * Fix indentation * Add manual to traefik redirect capture all rule (#933) * Introduce rolling docker config / secret update concept 🎉 🚀 (#952) * fixes * update comment * Update traefik router hardcoded priorities (#953) * Update traefik router hardcoded priorities * remove hardcoded priority from adminpanels * Configure redis replicas via ENV (#957) * Filestash: remove special docker node label (#959) * rabbit: configurable replicas (#964) * rabbit: configurable replicas * clean up * 💄 minor: Change DNS Server to Quad9 (#967) * wip * Add csi-s3 and have portainer use it * Change request @Hrytsuk 1GB max portainer volume size * Arch Linux Certificates Customization * Change DNS server for aws to swiss privacy focused one * revert wrong commit --------- Co-authored-by: Dustin Kaiser <[email protected]> * single replica (#968) * Remove docker api proxy from validate simcore settings (#972) * Add appmotiongateway add dalco * Add appmotiongateway add dalco - 2 * Add appmotiongateway add dalco - 3 * Seperate dalco-staging: disable redis special handling (#976) * wip * Add csi-s3 and have portainer use it * Change request @Hrytsuk 1GB max portainer volume size * Arch Linux Certificates Customization * Remove dalco special staging handling * remove accidental commit * remove accidental commit * Remove dalco staging special handling --------- Co-authored-by: Dustin Kaiser <[email protected]> * Fix deploy ops failure * Make curl in ensure_grafana_online_ timeout after 10s * Timeout in wait_graylog_is_online * Fix osparc.local pydantic validation failure director-v0 --------- Co-authored-by: Dustin Kaiser <[email protected]> Co-authored-by: Yury Hrytsuk <[email protected]> Co-authored-by: Sylvain <[email protected]>
mrnicegyu11
added a commit
that referenced
this pull request
Apr 7, 2025
* wip * Add csi-s3 and have portainer use it * Change request @Hrytsuk 1GB max portainer volume size * Fix wrong filename * Fix registry local deploy * Traefik local deployment fixes * Fix local deployment graylog provisioning * Fix j2, double venv * Add python version * Idempotency for admin-panels * Remove faulty command * Local deploy fixes * Clean Up Local Minio * init work * Remove unused code * Update Minio * Arch Linux Certificates Customization * Add grafana terrform tooling * Make osparc-config dotenv-precommit pass: Use all caps env-vars * Refactoring: jinja2 takes .env file path as explicit argument (like in osparc-config) * Make CI_ENV_FILE vailable in makefile * Refactor makefile targets * Add grafana terraform gitignore * Rename envvar: TF_STATE_S3_GRAFANAKEY * Remove old scripts, makefile targets * Remove unused files * undue arch style commit * Remove references to Tempo * CHange request YH: Stop trying tor ecah grafana eventually * Change request YH: Move tf scripts to terraform folder * Change request YH: stricter check * Add files remove typo * Add terraform fmt pre-commit hook * Use ansible.env file in lieu of ci.env if available * Rename and refactor * wip * wip * remove line * Makefile repo base dir without git * Grafana terraform ceph fixes * Fix indentation * Add manual to traefik redirect capture all rule (#933) * Introduce rolling docker config / secret update concept 🎉 🚀 (#952) * fixes * update comment * Update traefik router hardcoded priorities (#953) * Update traefik router hardcoded priorities * remove hardcoded priority from adminpanels * Configure redis replicas via ENV (#957) * Filestash: remove special docker node label (#959) * rabbit: configurable replicas (#964) * rabbit: configurable replicas * clean up * 💄 minor: Change DNS Server to Quad9 (#967) * wip * Add csi-s3 and have portainer use it * Change request @Hrytsuk 1GB max portainer volume size * Arch Linux Certificates Customization * Change DNS server for aws to swiss privacy focused one * revert wrong commit --------- Co-authored-by: Dustin Kaiser <[email protected]> * single replica (#968) * Remove docker api proxy from validate simcore settings (#972) * Add appmotiongateway add dalco * Add appmotiongateway add dalco - 2 * Add appmotiongateway add dalco - 3 * Seperate dalco-staging: disable redis special handling (#976) * wip * Add csi-s3 and have portainer use it * Change request @Hrytsuk 1GB max portainer volume size * Arch Linux Certificates Customization * Remove dalco special staging handling * remove accidental commit * remove accidental commit * Remove dalco staging special handling --------- Co-authored-by: Dustin Kaiser <[email protected]> * Fix deploy ops failure * Make curl in ensure_grafana_online_ timeout after 10s * Timeout in wait_graylog_is_online * Fix osparc.local pydantic validation failure director-v0 * Move create tempo bucket function to monitoring stack makefile * wip * fix faulty commit * Add tempo as exporter target to otlp collector --------- Co-authored-by: Dustin Kaiser <[email protected]> Co-authored-by: Yury Hrytsuk <[email protected]> Co-authored-by: Sylvain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Removes special handling for dalco staging
Related issue/s
Related PR/s
Checklist