Update 3d-viewer to dy-sidecar with boot-modes and baked template data#162
Conversation
There was a problem hiding this comment.
We require a CI step that makes sure that this runs and it can be build. They usually look like so https://github.com/ITISFoundation/jupyter-math/blob/main/.github/workflows/check-image.yml
Without this step working, the automation build process will not work
Co-authored-by: Andrei Neagu <5694077+GitHK@users.noreply.github.com>
sanderegg
left a comment
There was a problem hiding this comment.
mostly wondering about hard-coding all these vtk file in there? is that really how this should be? are these not under license?
| - name: "Sylvain Anderegg" | ||
| email: "anderegg@itis.swiss" | ||
| affiliation: "IT'IS Foundation" | ||
| contact: anderegg@itis.swiss |
There was a problem hiding this comment.
did we not say these email addresses shall change to something like support or whatever?
There was a problem hiding this comment.
didnt hear about this one
There was a problem hiding this comment.
maybe if you can put my github email address instead...
35365065+sanderegg@users.noreply.github.com
|
|
||
| outputs: {} | ||
|
|
||
| boot-options: |
There was a problem hiding this comment.
not sure I get it here. are we now hard-coding these data inside?
previsously I think the template defined what was going in.
|
|
||
| outputs: {} | ||
|
|
||
| boot-options: |
There was a problem hiding this comment.
is it ok to put all these vip files inside?
|
@sanderegg maybe I am understanding it wrong, but this service's |
@mrnicegyu11 the inputs shall be brought in by the dynamic-sidecar (previously done by the integrated one when it was a legacy service). It was not meant to be a hard-coded service. |
I confirm, we changed this. When the service starts the inputs are already in place. |
What do these changes do?
osparc-master.speag.com