Skip to content

Update 3d-viewer to dy-sidecar with boot-modes and baked template data#162

Merged
mrnicegyu11 merged 11 commits intoITISFoundation:masterfrom
mrnicegyu11:2025/upgrade3DViewerToDySidecar
Jun 12, 2025
Merged

Update 3d-viewer to dy-sidecar with boot-modes and baked template data#162
mrnicegyu11 merged 11 commits intoITISFoundation:masterfrom
mrnicegyu11:2025/upgrade3DViewerToDySidecar

Conversation

@mrnicegyu11
Copy link
Copy Markdown
Member

What do these changes do?

  • Update 3d-viewer to dy-sidecar with boot-modes and baked template data
  • Portal Link templates must be updated to use the specific boot-mode to preload their data
  • This should be compatible I hope with the registry-syncer (CC @GitHK ?)
  • Tested to work on osparc-master.speag.com

@mrnicegyu11 mrnicegyu11 added this to the Bazinga! milestone Jun 11, 2025
@mrnicegyu11 mrnicegyu11 requested review from GitHK and mguidon June 11, 2025 08:50
@mrnicegyu11 mrnicegyu11 self-assigned this Jun 11, 2025
@mrnicegyu11 mrnicegyu11 requested a review from sanderegg as a code owner June 11, 2025 08:50
Copy link
Copy Markdown
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We require a CI step that makes sure that this runs and it can be build. They usually look like so https://github.com/ITISFoundation/jupyter-math/blob/main/.github/workflows/check-image.yml

Without this step working, the automation build process will not work

Copy link
Copy Markdown
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly wondering about hard-coding all these vtk file in there? is that really how this should be? are these not under license?

Comment on lines +9 to +12
- name: "Sylvain Anderegg"
email: "anderegg@itis.swiss"
affiliation: "IT'IS Foundation"
contact: anderegg@itis.swiss
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we not say these email addresses shall change to something like support or whatever?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt hear about this one

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe if you can put my github email address instead...
35365065+sanderegg@users.noreply.github.com


outputs: {}

boot-options:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I get it here. are we now hard-coding these data inside?
previsously I think the template defined what was going in.


outputs: {}

boot-options:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it ok to put all these vip files inside?

@mrnicegyu11
Copy link
Copy Markdown
Member Author

@sanderegg maybe I am understanding it wrong, but this service's entrypoint.sh relys on the inputs being present to execute the paraview binary. But it seems that the inputs are often only pulled after the start of the sidecar. My trick is to bake the required files into the docker image. Do you have other proposals?

@sanderegg
Copy link
Copy Markdown
Member

@sanderegg maybe I am understanding it wrong, but this service's entrypoint.sh relys on the inputs being present to execute the paraview binary. But it seems that the inputs are often only pulled after the start of the sidecar. My trick is to bake the required files into the docker image. Do you have other proposals?

@mrnicegyu11 the inputs shall be brought in by the dynamic-sidecar (previously done by the integrated one when it was a legacy service). It was not meant to be a hard-coded service.

@GitHK
Copy link
Copy Markdown
Contributor

GitHK commented Jun 12, 2025

@sanderegg maybe I am understanding it wrong, but this service's entrypoint.sh relys on the inputs being present to execute the paraview binary. But it seems that the inputs are often only pulled after the start of the sidecar. My trick is to bake the required files into the docker image. Do you have other proposals?

@mrnicegyu11 the inputs shall be brought in by the dynamic-sidecar (previously done by the integrated one when it was a legacy service). It was not meant to be a hard-coded service.

I confirm, we changed this. When the service starts the inputs are already in place.

@mrnicegyu11 mrnicegyu11 merged commit 1151fc8 into ITISFoundation:master Jun 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants