add test when no released solvers

Author: bisgaard-itis

packages/pytest-simcore/src/pytest_simcore/helpers/catalog_rpc_server.py

@@ -5,6 +5,8 @@
 # pylint: disable=unused-variable
 
 
+from dataclasses import dataclass
+
 from models_library.api_schemas_catalog.services import (
     LatestServiceGet,
     ServiceGetV2,
@@ -171,3 +173,20 @@ async def get_service_ports(
         return TypeAdapter(list[ServicePortGet]).validate_python(
             ServicePortGet.model_json_schema()["examples"],
         )
+
+
+@dataclass
+class ZeroListingCatalogRpcSideEffects:
+    """Catalog RPC mocks that return empty lists"""
+
+    async def list_services_paginated(*args, **kwargs): ...
+    async def get_service(*args, **kwargs): ...
+    async def update_service(*args, **kwargs): ...
+    async def get_service_ports(*args, **kwargs): ...
+    async def list_my_service_history_latest_first(*args, **kwargs):
+        return PageRpc[ServiceRelease].create(
+            [],
+            total=0,
+            limit=10,
+            offset=0,
+        )

services/api-server/tests/unit/conftest.py

@@ -459,8 +459,9 @@ def mocked_catalog_rest_api_base(
 
 @pytest.fixture
 def catalog_rpc_side_effects(request) -> Any:
-    param = request.param if request.param is not None else CatalogRpcSideEffects()
-    return param
+    if "param" in dir(request) and request.param is not None:
+        return request.param
+    return CatalogRpcSideEffects()
 
 
 @pytest.fixture

services/api-server/tests/unit/test_api_programs.py

@@ -2,7 +2,6 @@
 # pylint: disable=unused-variable
 # pylint: disable=too-many-arguments
 
-from dataclasses import dataclass
 from functools import partial
 from pathlib import Path
 from typing import Any
@@ -13,10 +12,9 @@
 from fastapi import status
 from httpx import AsyncClient
 from models_library.api_schemas_storage.storage_schemas import FileUploadSchema
-from models_library.rpc_pagination import PageRpc
-from models_library.services_history import ServiceRelease
 from models_library.users import UserID
 from pytest_mock import MockerFixture, MockType
+from pytest_simcore.helpers.catalog_rpc_server import ZeroListingCatalogRpcSideEffects
 from pytest_simcore.helpers.faker_factories import DEFAULT_FAKER
 from pytest_simcore.helpers.httpx_calls_capture_models import (
     CreateRespxMockCallback,
@@ -173,23 +171,8 @@ async def test_list_program_history(
     assert response.status_code == status.HTTP_200_OK
 
 
-@dataclass
-class _MockCatalogRpcSideEffects:
-    async def list_services_paginated(*args, **kwargs): ...
-    async def get_service(*args, **kwargs): ...
-    async def update_service(*args, **kwargs): ...
-    async def get_service_ports(*args, **kwargs): ...
-    async def list_my_service_history_latest_first(*args, **kwargs):
-        return PageRpc[ServiceRelease].create(
-            [],
-            total=0,
-            limit=10,
-            offset=0,
-        )
-
-
 @pytest.mark.parametrize(
-    "catalog_rpc_side_effects", [_MockCatalogRpcSideEffects()], indirect=True
+    "catalog_rpc_side_effects", [ZeroListingCatalogRpcSideEffects()], indirect=True
 )
 async def test_list_program_history_no_program(
     auth: httpx.BasicAuth,

services/api-server/tests/unit/test_api_solvers.py

@@ -10,6 +10,7 @@
 from fastapi import status
 from httpx import AsyncClient
 from models_library.api_schemas_api_server.pricing_plans import ServicePricingPlanGet
+from pytest_simcore.helpers.catalog_rpc_server import ZeroListingCatalogRpcSideEffects
 from pytest_simcore.helpers.httpx_calls_capture_models import CreateRespxMockCallback
 from simcore_service_api_server._meta import API_VTAG
 
@@ -73,3 +74,28 @@ async def test_get_latest_solver_release(
     if response.status_code == status.HTTP_200_OK:
         assert "id" in response.json()
         assert response.json()["id"] == solver_key
+
+
+@pytest.mark.parametrize(
+    "catalog_rpc_side_effects",
+    [ZeroListingCatalogRpcSideEffects()],
+    indirect=True,
+)
+@pytest.mark.parametrize(
+    "solver_key,expected_status_code",
+    [
+        ("simcore/services/comp/valid_solver", status.HTTP_404_NOT_FOUND),
+    ],
+)
+async def test_get_latest_solver_release_zero_releases(
+    client: AsyncClient,
+    mocked_catalog_rpc_api,
+    auth: httpx.BasicAuth,
+    solver_key: str,
+    expected_status_code: int,
+):
+    response = await client.get(
+        f"{API_VTAG}/solvers/{solver_key}/latest",
+        auth=auth,
+    )
+    assert response.status_code == expected_status_code