bugfix catalog history returning [] and test

Author: bisgaard-itis

services/api-server/src/simcore_service_api_server/_service_programs.py

@@ -70,6 +70,8 @@ async def list_program_history(
             offset=offset,
             limit=limit,
         )
+        if len(page) == 0:
+            return [], page_meta
 
         program_instance = await self._catalog_service.get(
             user_id=user_id,

services/api-server/tests/unit/conftest.py

@@ -457,9 +457,15 @@ def mocked_catalog_rest_api_base(
         yield respx_mock
 
 
+@pytest.fixture
+def catalog_rpc_side_effects(request) -> Any:
+    param = request.param if request.param is not None else CatalogRpcSideEffects()
+    return param
+
+
 @pytest.fixture
 def mocked_catalog_rpc_api(
-    app: FastAPI, mocker: MockerFixture
+    app: FastAPI, mocker: MockerFixture, catalog_rpc_side_effects: CatalogRpcSideEffects
 ) -> Iterable[dict[str, MockType]]:
     """
     Mocks the RPC catalog service API for testing purposes.
@@ -469,38 +475,37 @@ def get_mock_rabbitmq_rpc_client():
         return MagicMock()
 
     app.dependency_overrides[get_rabbitmq_rpc_client] = get_mock_rabbitmq_rpc_client
-    side_effects = CatalogRpcSideEffects()
 
     yield {
         "list_services_paginated": mocker.patch.object(
             catalog_rpc,
             "list_services_paginated",
             autospec=True,
-            side_effect=side_effects.list_services_paginated,
+            side_effect=catalog_rpc_side_effects.list_services_paginated,
         ),
         "get_service": mocker.patch.object(
             catalog_rpc,
             "get_service",
             autospec=True,
-            side_effect=side_effects.get_service,
+            side_effect=catalog_rpc_side_effects.get_service,
         ),
         "update_service": mocker.patch.object(
             catalog_rpc,
             "update_service",
             autospec=True,
-            side_effect=side_effects.update_service,
+            side_effect=catalog_rpc_side_effects.update_service,
         ),
         "list_my_service_history_latest_first": mocker.patch.object(
             catalog_rpc,
             "list_my_service_history_latest_first",
             autospec=True,
-            side_effect=side_effects.list_my_service_history_latest_first,
+            side_effect=catalog_rpc_side_effects.list_my_service_history_latest_first,
         ),
         "get_service_ports": mocker.patch.object(
             catalog_rpc,
             "get_service_ports",
             autospec=True,
-            side_effect=side_effects.get_service_ports,
+            side_effect=catalog_rpc_side_effects.get_service_ports,
         ),
     }
     app.dependency_overrides.pop(get_rabbitmq_rpc_client)

services/api-server/tests/unit/test_api_programs.py

@@ -2,6 +2,7 @@
 # pylint: disable=unused-variable
 # pylint: disable=too-many-arguments
 
+from dataclasses import dataclass
 from functools import partial
 from pathlib import Path
 from typing import Any
@@ -12,6 +13,8 @@
 from fastapi import status
 from httpx import AsyncClient
 from models_library.api_schemas_storage.storage_schemas import FileUploadSchema
+from models_library.rpc_pagination import PageRpc
+from models_library.services_history import ServiceRelease
 from models_library.users import UserID
 from pytest_mock import MockerFixture, MockType
 from pytest_simcore.helpers.faker_factories import DEFAULT_FAKER
@@ -168,3 +171,34 @@ async def test_list_program_history(
         f"/{API_VTAG}/programs/{program_key}/releases", auth=auth
     )
     assert response.status_code == status.HTTP_200_OK
+
+
+@dataclass
+class _MockCatalogRpcSideEffects:
+    async def list_services_paginated(*args, **kwargs): ...
+    async def get_service(*args, **kwargs): ...
+    async def update_service(*args, **kwargs): ...
+    async def get_service_ports(*args, **kwargs): ...
+    async def list_my_service_history_latest_first(*args, **kwargs):
+        return PageRpc[ServiceRelease].create(
+            [],
+            total=0,
+            limit=10,
+            offset=0,
+        )
+
+
+@pytest.mark.parametrize(
+    "catalog_rpc_side_effects", [_MockCatalogRpcSideEffects()], indirect=True
+)
+async def test_list_program_history_no_program(
+    auth: httpx.BasicAuth,
+    client: AsyncClient,
+    mocked_catalog_rpc_api: dict[str, MockType],
+):
+    program_key = "simcore/services/dynamic/my_program"
+    # Arrange
+    response = await client.get(
+        f"/{API_VTAG}/programs/{program_key}/releases", auth=auth
+    )
+    assert response.status_code == status.HTTP_200_OK