Skip to content

Commit 1450131

Browse files
committed
rename another function for coherence
1 parent 8240d5c commit 1450131

File tree

4 files changed

+12
-10
lines changed

4 files changed

+12
-10
lines changed

services/api-server/src/simcore_service_api_server/_service_programs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ async def list_program_history(
6363
offset: NonNegativeInt,
6464
limit: PositiveInt,
6565
) -> tuple[list[Program], PageMetaInfoLimitOffset]:
66-
page, page_meta = await self._catalog_service.list_release_history_sorted(
66+
page, page_meta = await self._catalog_service.list_release_history_latest_first(
6767
user_id=user_id,
6868
service_key=program_key,
6969
product_name=product_name,

services/api-server/src/simcore_service_api_server/_service_solvers.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ async def get_latest_release(
5151
solver_key: SolverKeyId,
5252
product_name: str,
5353
) -> Solver:
54-
releases, _ = await self._catalog_service.list_release_history_sorted(
54+
releases, _ = await self._catalog_service.list_release_history_latest_first(
5555
user_id=user_id,
5656
service_key=solver_key,
5757
product_name=product_name,
@@ -79,12 +79,14 @@ async def solver_release_history(
7979
limit: PositiveInt,
8080
) -> tuple[list[Solver], PageMetaInfoLimitOffset]:
8181

82-
releases, page_meta = await self._catalog_service.list_release_history_sorted(
83-
user_id=user_id,
84-
service_key=solver_key,
85-
product_name=product_name,
86-
offset=offset,
87-
limit=limit,
82+
releases, page_meta = (
83+
await self._catalog_service.list_release_history_latest_first(
84+
user_id=user_id,
85+
service_key=solver_key,
86+
product_name=product_name,
87+
offset=offset,
88+
limit=limit,
89+
)
8890
)
8991

9092
service_instance = await self._catalog_service.get(

services/api-server/src/simcore_service_api_server/services_rpc/catalog.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ async def list_latest_releases(
7171
)
7272
return page.data, meta
7373

74-
async def list_release_history_sorted(
74+
async def list_release_history_latest_first(
7575
self,
7676
*,
7777
product_name: ProductName,

services/api-server/tests/unit/test_services_catalog.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ async def test_catalog_service_read_solvers(
4949

5050
# Step 2: Select one release and list solver releases
5151
selected_solver = solver_releases_page[0]
52-
releases, meta = await catalog_service.list_release_history_sorted(
52+
releases, meta = await catalog_service.list_release_history_latest_first(
5353
product_name=product_name,
5454
user_id=user_id,
5555
service_key=selected_solver.id,

0 commit comments

Comments
 (0)