Skip to content

Commit 0baf9ab

Browse files
continue fixing
1 parent 4c66094 commit 0baf9ab

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

packages/models-library/src/models_library/boot_options.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from pydantic import BaseModel, ConfigDict, field_validator
1+
from pydantic import BaseModel, ConfigDict, ValidationInfo, field_validator
22
from typing_extensions import TypedDict
33

44
from .basic_types import EnvVarKey
@@ -17,8 +17,8 @@ class BootOption(BaseModel):
1717

1818
@field_validator("items")
1919
@classmethod
20-
def ensure_default_included(cls, v, values):
21-
default = values["default"]
20+
def ensure_default_included(cls, v, info: ValidationInfo):
21+
default = info.data["default"]
2222
if default not in v:
2323
msg = f"Expected default={default} to be present a key of items={v}"
2424
raise ValueError(msg)

packages/models-library/tests/test_services.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ def _find_pattern_entry(obj: dict[str, Any], key: str) -> Any:
182182

183183

184184
def test_boot_option_wrong_default() -> None:
185-
for example in [deepcopy(x) for x in BootOption.Config.schema_extra["examples"]]:
185+
for example in [deepcopy(x) for x in BootOption.model_config["json_schema_extra"]["examples"]]:
186186
with pytest.raises(ValueError):
187187
example["default"] = "__undefined__"
188188
assert BootOption(**example)
@@ -201,11 +201,12 @@ def test_service_docker_data_labels_convesion():
201201
# we want labels to look like io.simcore.a_label_property
202202
convension_breaking_fields: set[tuple[str, str]] = set()
203203

204-
fiedls_with_aliases: list[tuple[str, str]] = [
205-
(x.name, x.alias) for x in ServiceMetaDataPublished.__fields__.values()
204+
fields_with_aliases: list[tuple[str, str]] = [
205+
(name, info.alias) for name, info in ServiceMetaDataPublished.model_fields.items()
206+
if info.alias is not None
206207
]
207208

208-
for name, alias in fiedls_with_aliases:
209+
for name, alias in fields_with_aliases:
209210
if alias in FIELD_NAME_EXCEPTIONS:
210211
continue
211212
# check dashes and uppercase

0 commit comments

Comments
 (0)