refactoring

Author: odeimaiz

services/static-webserver/client/source/class/osparc/node/slideshow/NodeView.js

@@ -38,13 +38,6 @@ qx.Class.define("osparc.node.slideshow.NodeView", {
 
   statics: {
     LOGGER_HEIGHT: 28,
-
-    isPropsFormShowable: function(node) {
-      if (node && ("getPropsForm" in node) && node.getPropsForm()) {
-        return node.getPropsForm().hasVisibleInputs();
-      }
-      return false;
-    },
   },
 
   members: {
@@ -55,9 +48,14 @@ qx.Class.define("osparc.node.slideshow.NodeView", {
       this._settingsLayout.removeAll();
 
       const node = this.getNode();
-      const propsForm = node.getPropsForm();
-      if (propsForm && node.hasInputs()) {
-        this._settingsLayout.add(propsForm);
+      if (
+        node.isComputational() &&
+        node.hasInputs() &&
+        "getPropsForm" in node &&
+        node.getPropsForm() &&
+        node.getPropsForm().hasVisibleInputs()
+      ) {
+        this._settingsLayout.add(node.getPropsForm());
       }
 
       const showSettings = node.isComputational();

services/static-webserver/client/source/class/osparc/workbench/NodeUI.js

@@ -398,11 +398,10 @@ qx.Class.define("osparc.workbench.NodeUI", {
       }
 
       const lock = this.getChildControl("lock");
-      if (node.getPropsForm()) {
-        node.getPropsForm().bind("enabled", lock, "visibility", {
-          converter: val => val ? "excluded" : "visible"
-        });
-      }
+      node.getStudy().bind("pipelineRunning", lock, "visibility", {
+        converter: pipelineRunning => !pipelineRunning ? "visible" : "excluded"
+      });
+
       this.__markerBtn.show();
       this.getNode().bind("marker", this.__markerBtn, "label", {
         converter: val => val ? this.tr("Remove Marker") : this.tr("Add Marker")